Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix dedicated nodes links across all pages #3499

Merged
merged 2 commits into from
Oct 9, 2024
Merged

Conversation

samaradel
Copy link
Contributor

@samaradel samaradel commented Oct 3, 2024

Description

  • Fix dedicated node links across all pages.
  • Remove unwanted watch import.

Changes

  • Update the outdated dedicated node link on manual utils, affecting overall links.
  • Point dedicated node link of static website app to the same utils instead of hard-coded link.

Related Issues

Checklist

  • Tests included
  • Build pass
  • Documentation
  • Code format and docstrings
  • Screenshots/Video attached (needed for UI changes)

@@ -1,7 +1,7 @@
const BASE = window.env.MANUAL_URL;

export const manual = {
dedicated_machines: `${BASE}/documentation/dashboard/deploy/dedicated_machines.html`,
dedicated_machines: `${BASE}/documentation/dashboard/deploy/node_finder.html#dedicated-nodes`,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please fix the replace dedicated_machines in the billing_pricing as well
should follow the new node_finde url https://www.manual.grid.tf/documentation/dashboard/deploy/node_finder.html#billing--pricing

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@samaradel samaradel requested a review from 0oM4R October 7, 2024 10:23
@samaradel samaradel merged commit 4fd5606 into development Oct 9, 2024
10 checks passed
@samaradel samaradel deleted the development_manual branch October 9, 2024 07:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants