Reset the farm name value in the create farm dialog #3503
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samaradel
requested review from
AhmedHanafy725,
zaelgohary,
maayarosama,
MohamedElmdary,
Mahmoud-Emad,
amiraabouhadid,
AlaaElattar and
0oM4R
as code owners
samaradel
changed the title
0oM4R
requested changes
Oct 3, 2024
| color="anchor" | ||
| @click=" | ||
| showDialogue = false; | ||
| $emit('update:name', ''); |
There was a problem hiding this comment.
why do we pass the name to the parent it is not used as i see, i think this behavior need some refactor, no need to bind the farm name here
There was a problem hiding this comment.
it's just a reset for farm name on close
There was a problem hiding this comment.
we can just remove the name prop, it will reset the farm name.
we are not using the name on the parent component
There was a problem hiding this comment.
When I did it disappeared on blur before submit / close.
There was a problem hiding this comment.
this is not related to props, this related to the dialog component, u can try to add persistent to the dialog component
0oM4R
requested changes
Oct 17, 2024
0oM4R
approved these changes
Oct 20, 2024
AhmedHanafy725
approved these changes
Oct 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Reset the farm name value in the create farm dialog on submit and on close.
Changes
Screencast.from.03-10-24.15.29.28.webm
Related Issues
Tested Scenarios
Checklist