Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix farm ip pagination #3507

Merged
merged 1 commit into from
Oct 20, 2024
Merged

Fix farm ip pagination #3507

merged 1 commit into from
Oct 20, 2024

Conversation

amiraabouhadid
Copy link
Contributor

@amiraabouhadid amiraabouhadid commented Oct 7, 2024 •
edited
Loading

Changes

  • add pagination to ip table
  • move delete button out of table template buttom

Related Issues

#3443

Tested Scenarios

  • deleted pub ips and watched it reflect in table
  • changed page and page size and watched correct ips get displayed
  • checked that pub ips correspond correctly to their respective farm
  • checked top checkbox, it selected all ips, when unchecked it deselects all ips

@amiraabouhadid amiraabouhadid marked this pull request as ready for review October 7, 2024 06:05
0oM4R
0oM4R reviewed Oct 9, 2024
View reviewed changes
Copy link
Contributor

@0oM4R 0oM4R left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pagination works fine but i think we need to have a look on the style to be as the original table
image

Screencast.from.2024-10-09.11-18-09.webm

@amiraabouhadid amiraabouhadid marked this pull request as draft October 13, 2024 09:02
@amiraabouhadid amiraabouhadid marked this pull request as ready for review October 14, 2024 13:53
0oM4R
0oM4R reviewed Oct 15, 2024
View reviewed changes
Copy link
Contributor

@0oM4R 0oM4R left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#3507 (review)
Screenshot from 2024-10-15 12-32-39

UI still need some work, to be as the previous one, specially the height

@amiraabouhadid amiraabouhadid marked this pull request as draft October 15, 2024 10:07
@amiraabouhadid amiraabouhadid marked this pull request as ready for review October 15, 2024 11:58
@amiraabouhadid amiraabouhadid merged commit 56ca263 into development Oct 20, 2024
7 checks passed
@amiraabouhadid amiraabouhadid deleted the dev_fix_farm_ip_pagination branch October 20, 2024 07:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0oM4R 0oM4R 0oM4R approved these changes

@samaradel samaradel samaradel approved these changes

@AhmedHanafy725 AhmedHanafy725 Awaiting requested review from AhmedHanafy725 AhmedHanafy725 is a code owner

@zaelgohary zaelgohary Awaiting requested review from zaelgohary zaelgohary is a code owner

@maayarosama maayarosama Awaiting requested review from maayarosama maayarosama is a code owner

@MohamedElmdary MohamedElmdary Awaiting requested review from MohamedElmdary MohamedElmdary is a code owner

@Mahmoud-Emad Mahmoud-Emad Awaiting requested review from Mahmoud-Emad Mahmoud-Emad is a code owner

@AlaaElattar AlaaElattar Awaiting requested review from AlaaElattar AlaaElattar is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@amiraabouhadid @samaradel @0oM4R