Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update farm reload after farm creation #3544

Merged
merged 2 commits into from
Oct 22, 2024
Merged

Conversation

amiraabouhadid
Copy link
Contributor

@amiraabouhadid amiraabouhadid commented Oct 21, 2024

Changes

  • added previously removed event emitter in create farm
  • added prop change listener and changer in parent that emits reload farms in child

Related Issues

#3471

Tested Scenarios

  • created a farm, waited for reload then created another farm and waited for reload
  • need to wait 30seconds after farm creation for reload
  • tested it after page refresh

Checklist

@samaradel
Copy link
Contributor

samaradel commented Oct 22, 2024

So, there's no reload bar? I think we still need it, as the user doesn't know how much time he should wait.
@AhmedHanafy725 what do you think ?

@amiraabouhadid
Copy link
Contributor Author

So, there's no reload bar? I think we still need it, as the user doesn't know how much time he should wait. @AhmedHanafy725 what do you think ?

if we add a reload bar it wont be consistent with the behavior of other tables in the dashboard. so best to leave it as it is.

@amiraabouhadid amiraabouhadid merged commit a516b1b into development Oct 22, 2024
10 checks passed
@amiraabouhadid amiraabouhadid deleted the dev_farm_reload branch October 22, 2024 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants