Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add domain fail to list warning #3563

Merged
merged 3 commits into from
Oct 31, 2024
Merged

Add domain fail to list warning #3563

merged 3 commits into from
Oct 31, 2024

Conversation

amiraabouhadid
Copy link
Contributor

Changes

  • added error message to show how many domains were failed to list

Related Issues

#3389

Tested Scenarios

  • set failed gateways list to the gateways list got the message below

Checklist

  • Screenshots/Video attached (needed for UI changes)

Screenshot from 2024-10-29 15-18-48

@amiraabouhadid amiraabouhadid marked this pull request as ready for review October 29, 2024 12:21
0oM4R
0oM4R approved these changes Oct 31, 2024
View reviewed changes
Copy link
Contributor

@0oM4R 0oM4R left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@xmonader xmonader merged commit 4d8bbd4 into development Oct 31, 2024
10 checks passed
@xmonader xmonader deleted the dev_add_domain_warning branch October 31, 2024 10:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0oM4R 0oM4R 0oM4R approved these changes

@xmonader xmonader xmonader approved these changes

@AhmedHanafy725 AhmedHanafy725 Awaiting requested review from AhmedHanafy725 AhmedHanafy725 is a code owner

@zaelgohary zaelgohary Awaiting requested review from zaelgohary zaelgohary is a code owner

@maayarosama maayarosama Awaiting requested review from maayarosama maayarosama is a code owner

@MohamedElmdary MohamedElmdary Awaiting requested review from MohamedElmdary MohamedElmdary is a code owner

@Mahmoud-Emad Mahmoud-Emad Awaiting requested review from Mahmoud-Emad Mahmoud-Emad is a code owner

@AlaaElattar AlaaElattar Awaiting requested review from AlaaElattar AlaaElattar is a code owner

@samaradel samaradel Awaiting requested review from samaradel samaradel is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@amiraabouhadid @xmonader @0oM4R