Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FIX(KYC): fix kyc TC flow in deploy view #3628

Merged
merged 3 commits into from
Nov 13, 2024
Merged

FIX(KYC): fix kyc TC flow in deploy view #3628

merged 3 commits into from
Nov 13, 2024

Conversation

0oM4R
Copy link
Contributor

@0oM4R 0oM4R commented Nov 12, 2024

Description

added missing changes to the kyc flow in view layout

Related Issues

Tested Scenarios

  • checked the TC flow.
  • user must check the TC check box to click continue
  • on click on verify now the TC dialog will appear, if you user clicked on cancel or closed the dialog the kyc verification process wont start

Checklist

  • Tests included
  • Build pass
  • Documentation
  • Code format and docstrings
  • Screenshots/Video attached (needed for UI changes)

@samaradel
Copy link
Contributor

Screencast.from.12-11-24.11.25.17.webm

@0oM4R
Copy link
Contributor Author

0oM4R commented Nov 12, 2024

Screencast.from.12-11-24.11.25.17.webm

this is related to your ip, looks like cloudfront blocked you, you can restart your router and open from incognito
#3610 (comment)

@0oM4R 0oM4R added this to the 2.6.0 milestone Nov 13, 2024
@0oM4R 0oM4R merged commit 88861cf into development Nov 13, 2024
10 checks passed
@AhmedHanafy725 AhmedHanafy725 deleted the development_kyc_viewLayout branch November 13, 2024 10:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AhmedHanafy725 AhmedHanafy725 AhmedHanafy725 approved these changes

@maayarosama maayarosama maayarosama approved these changes

@zaelgohary zaelgohary Awaiting requested review from zaelgohary zaelgohary is a code owner

@MohamedElmdary MohamedElmdary Awaiting requested review from MohamedElmdary MohamedElmdary is a code owner

@Mahmoud-Emad Mahmoud-Emad Awaiting requested review from Mahmoud-Emad Mahmoud-Emad is a code owner

@amiraabouhadid amiraabouhadid Awaiting requested review from amiraabouhadid amiraabouhadid is a code owner

@AlaaElattar AlaaElattar Awaiting requested review from AlaaElattar AlaaElattar is a code owner

@samaradel samaradel Awaiting requested review from samaradel samaradel is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.6.0
Development

Successfully merging this pull request may close these issues.
4 participants
@0oM4R @samaradel @AhmedHanafy725 @maayarosama