Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Udhcp probe #1936

Merged
merged 4 commits into from
Mar 28, 2023
Merged

Udhcp probe #1936

merged 4 commits into from
Mar 28, 2023

Conversation

muhamadazmy
Copy link
Member

@muhamadazmy muhamadazmy commented Mar 28, 2023

This PR changes the way probing for interfaces is done. Instead of starting udhcp and leave it running then check if the interface got an IP. Instead what we do is that we run udhcpc with a different script that just prints the lease information received by udhcpc as a json object.

Udhcpc then is started with few extra flags that makes it exit the moment is received or times out.

This make it faster and much better to debug what happens if a node did not receive a dhcp lease.

Note: The script appears in 2 locations because:

  • Old images that is already booted needs a copy of that script so updated networkd can work normally (since probe code now uses it)
  • New images need to include this script as well (0-initrafms) hence script is also included in bootstrap that is already merged to main.

@muhamadazmy muhamadazmy marked this pull request as ready for review March 28, 2023 10:45
@muhamadazmy muhamadazmy merged commit cba88c9 into main Mar 28, 2023
@muhamadazmy muhamadazmy deleted the udhcp-probe branch March 28, 2023 11:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants