Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

show available resources in zui #1971

Merged
merged 4 commits into from
Jul 12, 2023
Merged

show available resources in zui #1971

merged 4 commits into from
Jul 12, 2023

Conversation

MarioBassem
Copy link
Contributor

@MarioBassem MarioBassem marked this pull request as ready for review May 23, 2023 11:15
@muhamadazmy muhamadazmy force-pushed the main_show_available_resources_zui branch from 4fc0074 to 7ed3581 Compare July 11, 2023 05:13
@muhamadazmy
Copy link
Member

image

The UI is trimmed because it doesn't fit on the smallest window size. I think you will have to try to compress the tables more. (for example the but the resources and the usage tables next to each other instead of on top of each other.

@muhamadazmy
Copy link
Member

I think the tty height is 24 lines only.

@MarioBassem MarioBassem force-pushed the main_show_available_resources_zui branch from 7ed3581 to 345303b Compare July 11, 2023 14:26
@muhamadazmy
Copy link
Member

I pushed a commit to actually use table columns instead of formatting everyting in one cell, the CPU and Memory titles can have their own cell, then the values is shown in a separate cell. then updates need to only change the value in the correct cell

image

this reads easier imho

@muhamadazmy muhamadazmy merged commit cf9e816 into main Jul 12, 2023
@muhamadazmy muhamadazmy deleted the main_show_available_resources_zui branch July 12, 2023 06:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@muhamadazmy muhamadazmy muhamadazmy approved these changes

@delandtj delandtj Awaiting requested review from delandtj

@ashraffouda ashraffouda Awaiting requested review from ashraffouda ashraffouda is a code owner

@rawdaGastan rawdaGastan Awaiting requested review from rawdaGastan rawdaGastan is a code owner

@xmonader xmonader Awaiting requested review from xmonader xmonader is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MarioBassem @muhamadazmy