use latest tfchain client and use uptimev2 #1978
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The uptime v2 also uses a local timestamp hint to make sure that reported uptie is in an acceptable range
muhamadazmy
requested review from
delandtj,
MarioBassem,
ashraffouda,
rawdaGastan and
xmonader
as code owners
xmonader
reviewed
Jun 14, 2023
| @@ -57,7 +57,7 @@ func (u *Uptime) SendNow() (types.Hash, error) { | |||
| return types.Hash{}, errors.Wrap(err, "failed to get uptime") | |||
| } | |||
|
|
|||
| return sub.UpdateNodeUptime(u.id, uptime) | |||
| return sub.UpdateNodeUptimeV2(u.id, uptime, uint64(time.Now().Unix())) | |||
There was a problem hiding this comment.
can you please add in the documentation the change in behavior
xmonader
approved these changes
Jun 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The uptime v2 also uses a local timestamp hint to make sure that reported uptie is in an acceptable range