add all available endpoints to zos environment #2415
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Eslam-Nawara
requested review from
muhamadazmy,
delandtj,
MarioBassem,
ashraffouda,
rawdaGastan and
xmonader
as code owners
iwanbk
reviewed
Sep 5, 2024
qemu/vm.sh
Outdated
| @@ -8,7 +8,7 @@ kernelargs="" | |||
| bridge=zos0 | |||
| graphics="-nographic -nodefaults" | |||
| smp=1 | |||
There was a problem hiding this comment.
why changing this file?
looks like need separate PR for this
There was a problem hiding this comment.
this was by mistake, removed it
Eslam-Nawara
force-pushed
the
add-all-available-endpoints-to-zos-env
branch
from
dcb7b75 to
ba93865
Compare
Eslam-Nawara
force-pushed
the
add-all-available-endpoints-to-zos-env
branch
from
ba93865 to
a900c92
Compare
Eslam-Nawara
force-pushed
the
add-all-available-endpoints-to-zos-env
branch
2 times, most recently
from
7d49b65 to
2664e82
Compare
Eslam-Nawara
force-pushed
the
add-all-available-endpoints-to-zos-env
branch
from
2664e82 to
88fae6c
Compare
rawdaGastan
requested changes
Sep 8, 2024
| Str("terms and conditions link", termsAndConditionsLink). | ||
| Str("terms and conditions hash", termsAndConditionsHash). | ||
| Msg("method called") | ||
| g.mu.Lock() | ||
| defer g.mu.Unlock() | ||
| return g.sub.EnsureAccount(g.identity, activationURL, termsAndConditionsLink, termsAndConditionsHash) | ||
| for _, url := range activationURL { | ||
| if info, err = g.sub.EnsureAccount(g.identity, url, termsAndConditionsLink, termsAndConditionsHash); err == nil { |
There was a problem hiding this comment.
I think we need to check the error according to this threefoldtech/tfchain#986
|
created new node to test supporting multiple activation service urls
|
rawdaGastan
previously approved these changes
Sep 9, 2024
Eslam-Nawara
force-pushed
the
add-all-available-endpoints-to-zos-env
branch
from
1bd39d9 to
1247394
Compare
rawdaGastan
approved these changes
Sep 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
add all available endpoints to zos environment
Changes
add all available endpoints to zos environment
Related Issues
Checklist