Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add compatibility with aiohttp 2.3.1 #38

Merged
merged 1 commit into from
Oct 20, 2017
Merged

Add compatibility with aiohttp 2.3.1 #38

merged 1 commit into from
Oct 20, 2017

Conversation

ppaeps
Copy link
Contributor

@ppaeps ppaeps commented Oct 20, 2017

The finish_connections method has been deprecated (ref: aio-libs/aiohttp#2006) and was replaced
with shutdown. No functional change.

============================= test session starts ==============================
platform freebsd11 -- Python 3.6.3, pytest-3.2.3, py-1.4.34, pluggy-0.4.0
Using event loop: asyncio
rootdir: /wrkdirs/usr/ports/devel/py3-threema-msgapi/work/threema-msgapi-sdk-python-3.0.6, inifile:
plugins: asyncio-0.8.0
collected 104 items

tests/test_api.py ...................................................................
tests/test_base.py ...
tests/test_blocking_api.py ......
tests/test_callback.py ......
tests/test_cli.py ......................

========================= 104 passed in 23.54 seconds ==========================

The `finish_connections` method has been deprecated and was replaced
with `shutdown`.  No functional change.
@ppaeps
Copy link
Contributor Author

ppaeps commented Oct 20, 2017

I'm not sure why Travis is complaining about this. I just checked on Python 3.5 and 3.6 with asyncio and it's all happy here. Perhaps it's just Python on Linux that's broken? I do not have Linux systems to test on.

@lgrahl
Copy link
Contributor

lgrahl commented Oct 20, 2017

I'm not sure why Travis is complaining about this.

Flaky tests. 😒 I've restarted them.

@codecov-io
Copy link

codecov-io commented Oct 20, 2017

Codecov Report

Merging #38 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #38   +/-   ##
=======================================
  Coverage   60.22%   60.22%           
=======================================
  Files           9        9           
  Lines        1335     1335           
  Branches      129      129           
=======================================
  Hits          804      804           
  Misses        484      484           
  Partials       47       47
Impacted Files Coverage Δ
threema/gateway/e2e.py 78.87% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e75c374...07a8f66. Read the comment docs.

@lgrahl lgrahl merged commit 7467438 into threema-ch:master Oct 20, 2017
@lgrahl
Copy link
Contributor

lgrahl commented Oct 20, 2017

I assume there's no rush for release, correct?

@ppaeps
Copy link
Contributor Author

ppaeps commented Oct 20, 2017

Correct. No rush!

Thanks for the merge.

@ppaeps ppaeps deleted the aiohttp-2.3.1 branch October 21, 2017 10:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants