add config timeout_verify #198
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- remove hardcoded 60 seconds timeout during verify, as with pack200 this may fail on slow systems - introduce new config "timeout_verify" with 60 seconds default - handle timeout with aborting the launch
|
This looks good, but I'm going to change the config to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
remove hardcoded 60 seconds timeout during verify, as with pack200
this may fail on slow systems (we experience 120 seconds and more for 12mb pack.gz)
introduce new config "timeout_verify" with 60 seconds default
handle timeout with aborting the launch
the Problem was actually introduced by Dynamic Fair Share Scheduling in Remote Desktop Services/ Terminal Services (RDS), help to solve the issue in windows can be found at http://www.ryslander.com/disable-fair-sharing-in-windows-server/