Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

zip files supported as resources #210

Merged

Conversation

sergiorussia
Copy link
Contributor

@sergiorussia sergiorussia commented May 5, 2019

see #206 (comment) for reasoning.

verified changes on my project, works just fine.

@samskivert, as file name manipulations are scattered all over the project i could miss something, pls point me out if i did.

@sergiorussia
Copy link
Contributor Author

successful deployment with java_local_dir = jre and java_location = [linux-amd64] /files/java/java_linux_64.zip:

2019/05/05 19:57:56:273 INFO Using appdir from command line: /home/sergio/opt/my-app
2019/05/05 19:57:56:277 INFO ------------------ VM Info ------------------
2019/05/05 19:57:56:278 INFO -- OS Name: Linux
2019/05/05 19:57:56:278 INFO -- OS Arch: amd64
2019/05/05 19:57:56:278 INFO -- OS Vers: 4.18.0-18-generic
2019/05/05 19:57:56:278 INFO -- Java Vers: 1.8.0_191
2019/05/05 19:57:56:278 INFO -- Java Home: /usr/lib/jvm/java-8-openjdk-amd64/jre
2019/05/05 19:57:56:279 INFO -- User Name: sergio
2019/05/05 19:57:56:279 INFO -- User Home: /home/sergio
2019/05/05 19:57:56:279 INFO -- Cur dir: /home/sergio/dev/getdown
2019/05/05 19:57:56:279 INFO ---------------------------------------------
2019/05/05 19:57:56:570 INFO Getdown starting [version=1.8.4-SNAPSHOT, built=2019-05-05 18:23]
2019/05/05 19:57:56:581 INFO Checking whether we need to use a proxy...
2019/05/05 19:57:56:767 INFO Downloading 0 resources [totalBytes=0, maxConcurrent=3]
2019/05/05 19:57:56:769 INFO Testing whether proxy is needed, via: http://app/files/beta/201905051855/getdown.txt
2019/05/05 19:57:56:860 INFO No proxy appears to be needed.
2019/05/05 19:57:56:883 INFO Downloading 0 resources [totalBytes=0, maxConcurrent=3]
2019/05/05 19:57:56:895 INFO Able to lock for updates: true
2019/05/05 19:57:56:920 INFO Verifying application: http://app/files/beta/201905051855/
2019/05/05 19:57:56:921 INFO Version: 201905051855
2019/05/05 19:57:56:921 INFO Class: app.Main
2019/05/05 19:57:56:957 INFO Unable to read version file: /home/sergio/opt/my-app/version.txt (No such file or directory)
2019/05/05 19:57:56:996 INFO Verified resources [count=40, size=33561k, duration=30ms]
2019/05/05 19:57:56:997 INFO Checking Java version [current=1080191, wantMin=1080192, wantMax=1080192]
2019/05/05 19:57:56:998 INFO Checking version of unpacked JVM [vers=1080191].
2019/05/05 19:57:56:998 WARNING An exact Java VM version is required. [current=1080191, required=1080192]
2019/05/05 19:57:56:998 INFO Attempting to update Java VM...
2019/05/05 19:57:57:002 INFO Downloading 1 resources [totalBytes=84584201, maxConcurrent=3]
2019/05/05 19:57:57:011 INFO Downloading resource [url=http://app/files/java/java_linux_64.zip, size=84584201]
2019/05/05 19:58:20:744 INFO - /home/sergio/opt/my-app/jre.zip_new
2019/05/05 19:58:22:619 INFO Regenerating classes.jsa for /home/sergio/opt/my-app/jre/bin/java...
2019/05/05 19:58:22:620 INFO Verifying application: http://app/files/beta/201905051855/
2019/05/05 19:58:22:620 INFO Version: 201905051855
2019/05/05 19:58:22:621 INFO Class: app.Main
2019/05/05 19:58:22:624 INFO Unable to read version file: /home/sergio/opt/my-app/version.txt (No such file or directory)
2019/05/05 19:58:22:643 INFO Verified resources [count=40, size=33561k, duration=13ms]
2019/05/05 19:58:22:644 INFO Checking Java version [current=1080191, wantMin=1080192, wantMax=1080192]
2019/05/05 19:58:22:645 INFO Checking version of unpacked JVM [vers=1080192].
2019/05/05 19:58:22:645 INFO Installing 0 downloaded resources:
2019/05/05 19:58:22:645 INFO Install completed.
2019/05/05 19:58:22:657 INFO Didn't find any custom environment variables, not setting any.
2019/05/05 19:58:22:657 INFO Running /home/sergio/opt/my-app/jre/bin/java
  -classpath
  /home/sergio/opt/my-app/app.jar
  -Dcom.threerings.getdown=true
  -XX:+UseG1GC
  -XX:+UseStringDeduplication
  app.Main

Process finished with exit code 0

@sergiorussia
Copy link
Contributor Author

@samskivert i assume that you are busy so can you pls provide any ETA?

@samskivert samskivert merged commit 4a13760 into threerings:master May 9, 2019
@sergiorussia sergiorussia deleted the feature/zip-files-support branch May 9, 2019 19:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants