Fix CVE-2024-28820 #92
Open
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
An attacker who can control the challenge/response password field could, with a valid LDAP username, pass a string with more than 14 colons into this field, causing a buffer overflow. This happens before the number of tokens is checked for validity below. This commit ensures that the loop bails before attempting to write past the end of tokenIndexes; as of the currently-published protocol, any response with more than 15 fields is certainly invalid (and will be rejected below).
bob-beck
pushed a commit
to openbsd/ports
that referenced
this pull request
Jul 1, 2024
|
@samskivert I see that you are previously one of the most active committers to this repository. I just wanted to bring this critical CVE to your attention. I'm guessing that this project is abandoned, and as such it may be pertinent to put a warning banner on the readme file to discourage future use of this project if that is the case. Additionally, the business that is said to provide support per the readme has closed and the security contact email address on the readme was unreachable during the CVE notification process. |
13 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An attacker who can control the challenge/response password field could, with a valid LDAP username, pass a string with more than 14 colons into this field, causing a buffer overflow. This happens before the number of tokens is checked for validity below.
This commit ensures that the loop bails before attempting to write past the end of tokenIndexes; as of the currently-published protocol, any response with more than 15 fields is certainly invalid (and will be rejected below).