[228] Connection meter discrepancy #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- adds logic to assign the participantId of the current user if no participantId is provided through the props
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trello Card
The only file for review is
react/features/connection-indicator/components/web/TvtConnectionIndicator.js! All other new files are needed for development purposes.Description
In this PR we are fixing a bug in the top-bar connection indicator not showing the current participant connections status property.
Reason for the bug
In the TvtConnectionIndicator (ex ConnectionIndicator) the participant id was not assigned in case if the
participantIdis not passed to the component as a property.As a consequence, the component can not subscribe properly for the update stats events.
Fix
Adds reassigning of the
participantIdno matter if the prop is passed or not.Additional changes
webpack.config.jsfile