Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[315] Hide jitsi reconnecting screen #19

Merged
merged 4 commits into from
Jan 5, 2021

Conversation

Jazastry
Copy link

@Jazastry Jazastry commented Jan 4, 2021

Trello Card

Description

In the PR we are adding functionality to hide the reload overlay
reload-overlay
By passing the new custom interface_config flag HIDE_RELOAD_OVERLAY.

Additional changes

We also hide the default jitsi moderator icon from the custom top bar.
Selection_001

- adds new interface_config custom flag HIDE_RELOAD_OVERLAY which if
  true hides the reload overlay
Copy link
Member

@kachar kachar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Jazastry The update looks good

I want to confirm one scenario with you if we may - is the interval timer going to reload the window after 10 or 30 seconds even if it's being hidden or this has been bypassed as well.

I'm referring to the following code block:

this._interval
= setInterval(
() => {
if (this.state.timeLeft === 0) {
if (this._interval) {
clearInterval(this._interval);
this._interval = undefined;
}
this.props.dispatch(reloadNow());
} else {
this.setState(prevState => {
return {
timeLeft: prevState.timeLeft - 1
};
});
}
},
1000);

@kachar kachar merged commit 1e87322 into threeveta-web-master Jan 5, 2021
@kachar kachar deleted the 315-hide-jitsi-reconnecting-screen branch January 5, 2021 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants