[216] [Jitsi Facelift] Settings dialog is broken #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- makes connection indicator to resize according to the connection status - worse status bigger icon - makes participants videolayout to have red shadow if connection is low - makes poor connection notification to show if the connection of connectiond participants lowers, if connection improves the notification is removed without user interaction - fixes paticipants videolayout hover styling - moves _participants-right-strip.scss to _participants.scss as this module is responsible not only for the right strip styling
- fixes the settings dialog not displayed
- the cause of the dialog disappearing is that the messages continer
and the settings-dialog is the same element, so the notifications
facelift styles was orerriding the dialog styles incorrectly
- updates the settings dialog styling according to the required designs
- in order to be possible to click the buttons of the bottom control strip we are moving the controls over the notifications nad adding gradient background in order to make buttons pop-over the notifications
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trello Card
Description
In this PR we are fixing bug in the jitsi Settings dialog display:
Additional changes
We are using the moment to upgrade the styling of the settings-dialog according to the required new designs.
In order for the bottom controls to be clickable, we are moving them over the notifications and adding slight gradient to the background.
