delegate function belongs to Checkpoints abstract contract interface

threshold-network · Oct 6, 2021 · 4c21141 · 4c21141
1 parent 23664a2
commit 4c21141
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 3 deletions.
diff --git a/contracts/test/TestStakingCheckpoints.sol b/contracts/test/TestStakingCheckpoints.sol
@@ -31,4 +31,6 @@ contract TestStakingCheckpoints is Checkpoints {
 
         tToken.transfer(msg.sender, amount);
     }
+
+    function delegate(address delegator, address delegatee) internal virtual override {}
 }
diff --git a/contracts/token/T.sol b/contracts/token/T.sol
@@ -125,7 +125,7 @@ contract T is ERC20WithPermit, MisfundRecovery, Checkpoints {
         _moveVotingPower(delegates(from), delegates(to), safeAmount);
     }
 
-    function delegate(address delegator, address delegatee) internal virtual {
+    function delegate(address delegator, address delegatee) internal virtual override {
         address currentDelegate = delegates(delegator);
         uint96 delegatorBalance = SafeCast.toUint96(balanceOf[delegator]);
         _delegates[delegator] = delegatee;

diff --git a/contracts/utils/Checkpoints.sol b/contracts/utils/Checkpoints.sol
@@ -49,8 +49,7 @@ abstract contract Checkpoints {
         uint256 newBalance
     );
 
-    //FIXME: Add this as an abstract function of Checkpoints
-    // function delegate(address delegator, address delegatee) internal virtual;
+    function delegate(address delegator, address delegatee) internal virtual;
 
     /**
      * @dev Get the `pos`-th checkpoint for `account`.
-Original file line number
+Diff line change
@@ Expand Up / @@ -31,4 +31,6 @@ contract TestStakingCheckpoints is Checkpoints { @@
             tToken.transfer(msg.sender, amount);
         }
+        function delegate(address delegator, address delegatee) internal virtual override {}
     }