Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Lots of content fixes, deletions, updates #102

Merged
merged 14 commits into from
Dec 5, 2023
Merged

Lots of content fixes, deletions, updates #102

merged 14 commits into from
Dec 5, 2023

Conversation

mswilkison
Copy link
Contributor

@mswilkison mswilkison commented Nov 22, 2023 •
edited
Loading

Fixes or removes outdated and/or incorrect information and links, including:

  • Specify required node version in readme.
  • Remove quiz functionality (I'm skeptical anyone uses this and it's distracting)
  • Remove references and links to legacy staking post TIP-63
  • Remove non-maintained events schedule section
  • Add telegram and discourse forum links to navbar and footer
  • Remove incorrect governance section
  • Remove minters & guardians from home page (but leaves them in tbtc page)
  • Some small typos, broken links, etc
  • Link to defillama pool list rather than non-comprehensive manual list of tbtc and T pools

@mswilkison mswilkison linked an issue Nov 22, 2023 that may be closed by this pull request
Curve tbtcv2 pool is not listed on liquidity provider page #56
Closed
@github-actions GitHub Actions
Copy link

Preview uploaded to https://preview.threshold.network/simplify/index.html.

@mhluongo
Copy link
Member

PR description plz ser

@mswilkison
Copy link
Contributor Author

PR description plz ser

Added, but mostly a restatement of commit descriptions.

mhluongo
mhluongo reviewed Nov 27, 2023
View reviewed changes
Copy link
Member

@mhluongo mhluongo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple quick nits. The deployed site looks good, but I'd like a +1 from @michalsmiarowski or @erdogan to merge

src/content/pages/earn/token-holder.md
- label: Upgrade to T
url: https://dashboard.threshold.network/upgrade
- label: Delegate Vote
url: https://delegates.threshold.network
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This domain doesn't appear to resolve?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

asked for clarification on eta here: https://discord.com/channels/866378471868727316/870386636507185202/1178733196263825499

src/hooks/useBalanceOfDAOTreasury.ts
@@ -4,8 +4,8 @@ import { FixedNumber } from "ethers"
import { CoingeckoID, exchangeAPI, formatUnits } from "../utils"
import { useERC20TokensBalanceCall } from "./useERC20TokensBalanceCall"

// https://etherscan.io/address/0x9f6e831c8f8939dc0c830c6e492e7cef4f9c2f5f
const DAO_TREASURY_ADDRESS = "0x9f6e831c8f8939dc0c830c6e492e7cef4f9c2f5f"
// https://etherscan.io/address/0x87F005317692D05BAA4193AB0c961c69e175f45f
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed this is the DAO's Timelock address

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It'd be really nice to include treasury details beyond just the timelock on the site somewhere. Outside the scope of this PR of course

Copy link
Contributor Author

@mswilkison mswilkison Nov 27, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It'd be really nice to include treasury details beyond just the timelock on the site somewhere. Outside the scope of this PR of course

ya... query will just be more complex b/c need to capture LP and vote-escrowed positions, x-chain, etc

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if zapper or debank provide some kind of api or embed?

jMyles
jMyles reviewed Nov 29, 2023
View reviewed changes
src/content/pages/ecosystem/index.md
@@ -203,6 +175,11 @@ community:
description: Ask questions and engage with our community.
url: https://discord.gg/Threshold
rightIcon: /images/external-arrow.svg
- leftIcon: /images/telegram-social.svg
title: Telegram
description: Ask questions and engage with our community.
Copy link

@jMyles jMyles Nov 29, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it worth saying, "Ask questions and engage with our community. Beware of scammers - we won't DM you first." ?

Or are we finally at the point where such things are implicit and common knowledge? :-)

erdogan
erdogan requested changes Nov 29, 2023
View reviewed changes
Copy link

@erdogan erdogan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mswilkison all looks good to me. Two minor notes:

  • the delegates site is still offline
  • small typo (Governance), added an inline comment for it

@github-actions GitHub Actions
Copy link

Preview uploaded to https://preview.threshold.network/simplify/index.html.

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 2, 2023

Preview uploaded to https://preview.threshold.network/simplify/index.html.

MacLane Wilkison added 14 commits December 2, 2023 08:26
@mswilkison
Specify node version
2ed24be 
Signed-off-by: MacLane Wilkison <maclanewilkison@MacLanes-MacBook-Pro.local>
Signed-off-by: MacLane Wilkison <maclane@nucypher.com>
@mswilkison
Remove quiz banner from index and role pages, and from Footer
e10ccd4 
Signed-off-by: MacLane Wilkison <maclanewilkison@MacLanes-MacBook-Pro.local>
Signed-off-by: MacLane Wilkison <maclane@nucypher.com>
@mswilkison
Remove references to legacy stakes post TIP-063
23ff4e2 
Signed-off-by: MacLane Wilkison <maclanewilkison@MacLanes-MacBook-Pro.local>
Signed-off-by: MacLane Wilkison <maclane@nucypher.com>
@mswilkison
nucypher.com redirects to threshold.network so replace website link w…
076a623 
…ith github

Signed-off-by: MacLane Wilkison <maclanewilkison@MacLanes-MacBook-Pro.local>
Signed-off-by: MacLane Wilkison <maclane@nucypher.com>
@mswilkison
Remove programs and events section from ecosystem page since hopeless…
1a3c0cd 
…ly out of date and unmaintained

Signed-off-by: MacLane Wilkison <maclanewilkison@MacLanes-MacBook-Pro.local>
Signed-off-by: MacLane Wilkison <maclane@nucypher.com>
@mswilkison
Remove 101.xyz which was shutdown
e3b3d76 
Signed-off-by: MacLane Wilkison <maclanewilkison@MacLanes-MacBook-Pro.local>
Signed-off-by: MacLane Wilkison <maclane@nucypher.com>
@mswilkison
Add telegram to community links
386d990 
Signed-off-by: MacLane Wilkison <maclanewilkison@MacLanes-MacBook-Pro.local>
Signed-off-by: MacLane Wilkison <maclane@nucypher.com>
@mswilkison
Add Discourse to footer and navbar
112997b 
Signed-off-by: MacLane Wilkison <maclanewilkison@MacLanes-MacBook-Pro.local>
Signed-off-by: MacLane Wilkison <maclane@nucypher.com>
@mswilkison
Remove minters and guardians from home page and update bug bounty
1a3d079 
Signed-off-by: MacLane Wilkison <maclanewilkison@MacLanes-MacBook-Pro.local>
Signed-off-by: MacLane Wilkison <maclane@nucypher.com>
@mswilkison
Remove redundant and incorrect governance detail section
6111847 
Signed-off-by: MacLane Wilkison <maclanewilkison@MacLanes-MacBook-Pro.local>
Signed-off-by: MacLane Wilkison <maclane@nucypher.com>
@mswilkison
Fix or remove outdated info
49c8ec8 
Signed-off-by: MacLane Wilkison <maclanewilkison@MacLanes-MacBook-Pro.local>
Signed-off-by: MacLane Wilkison <maclane@nucypher.com>
@mswilkison
Remove v1->v2 vending machine link, link to DefiLlama LP list rather …
f780197 
…than specific pools

Signed-off-by: MacLane Wilkison <maclanewilkison@MacLanes-MacBook-Pro.local>
Signed-off-by: MacLane Wilkison <maclane@nucypher.com>
@mswilkison
More fixes
8225fd8 
Signed-off-by: MacLane Wilkison <maclanewilkison@MacLanes-MacBook-Pro.local>
Signed-off-by: MacLane Wilkison <maclane@nucypher.com>
@mswilkison
Fix typo
ee3f9c2 
Signed-off-by: MacLane Wilkison <maclanewilkison@MacLanes-MacBook-Pro.local>
Signed-off-by: MacLane Wilkison <maclane@nucypher.com>
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 2, 2023

Preview uploaded to https://preview.threshold.network/simplify/index.html.

@mswilkison
Copy link
Contributor Author

Force pushed to sign + verify commits. Ready for merge.

@mswilkison mswilkison merged commit d0006cf into main Dec 5, 2023
3 checks passed
@mswilkison mswilkison deleted the simplify branch December 5, 2023 18:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mhluongo mhluongo mhluongo left review comments

@jMyles jMyles jMyles left review comments

@erdogan erdogan erdogan approved these changes

@michalsmiarowski michalsmiarowski Awaiting requested review from michalsmiarowski

@r-czajkowski r-czajkowski Awaiting requested review from r-czajkowski

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Curve tbtcv2 pool is not listed on liquidity provider page
4 participants
@mswilkison @mhluongo @erdogan @jMyles