Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Taco section in home page #106

Merged
merged 9 commits into from
Dec 22, 2023
Merged

Add Taco section in home page #106

merged 9 commits into from
Dec 22, 2023

Conversation

evandrosaturnino
Copy link
Contributor

@evandrosaturnino evandrosaturnino commented Dec 14, 2023 •
edited
Loading

Description

Add Taco Section to the website home page.

  • Add taco section in home page - 0f0ac42

Figma's design prototype: https://www.figma.com/file/AFYQHD8qWxJwNjryGvelVC/Taco-Section?type=design&node-id=61-1235&mode=design&t=H8cV1TsjluQLWo1j-0

Notice

  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?

Pull Request Type

  • New Feature (Breaking/Non-breaking Change)

Issue (if applicable)

Closes issue #90

Testing

Please outline all testing steps

  1. Clone the repo - git clone https://github.com/threshold-network/website.git
  2. Install dependencies - yarn install
  3. Run the app - yarn start

@github-actions GitHub Actions
Copy link

Preview uploaded to https://preview.threshold.network/taco-section/index.html.

@evandrosaturnino evandrosaturnino marked this pull request as ready for review December 16, 2023 02:59
@github-actions GitHub Actions
Copy link

Preview uploaded to https://preview.threshold.network/taco-section/index.html.

michalsmiarowski
michalsmiarowski requested changes Dec 22, 2023
View reviewed changes
Copy link
Contributor

@michalsmiarowski michalsmiarowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left one small comments and I think we'are good to go. Good job!

src/content/pages/index.md Outdated Show resolved Hide resolved
@evandrosaturnino @michalsmiarowski
Refactor taco section buttons variant to external
97a64e2 
Co-authored-by: Michał Śmiarowski <40306834+michalsmiarowski@users.noreply.github.com>
@github-actions GitHub Actions
Copy link

Preview uploaded to https://preview.threshold.network/taco-section/index.html.

michalsmiarowski
michalsmiarowski approved these changes Dec 22, 2023
View reviewed changes
Copy link
Contributor

@michalsmiarowski michalsmiarowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@michalsmiarowski michalsmiarowski merged commit 0b75908 into main Dec 22, 2023
3 checks passed
@michalsmiarowski michalsmiarowski deleted the taco-section branch December 22, 2023 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michalsmiarowski michalsmiarowski michalsmiarowski approved these changes

@r-czajkowski r-czajkowski Awaiting requested review from r-czajkowski

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@evandrosaturnino @michalsmiarowski