Provide "decode" code generation for the streaming variants for all other types #496

witriew · 2021-06-16T05:18:01Z

#495 provided the code generation for streaming reads of enums off of the wire.
Provide the streaming read generators for all of the other types.

Doing so meant providing a StreamGenerator that plumbs into the existing
generators. This StreamGenerator only provides the "decoding" mechanism,
leveraging #491 for reading the raw Thrift encoding off of the wire.

In addition to providing a StreamGenerator, the list, map, set, enum, typdef,
and struct generators all added a Decoder method that will appropriately
recurse and iterate to generate the proper, mirrored readers for the raw wire
representation.

The Decode and DecodePtr methods for StreamGenerator then hook into the
templated generator itself, providing the templated decode and decodePtr
calls that will be used where necessary.

The existing tests were leveraged to make sure that the streaming reads were
compatible with the current binary writes and that no data was lost. In doing
so, a 'genericized' function that will perform the cross-products of
encoding/writing and decoding/reading.

A benchmark was also added to evaluate the new streaming reads. The following
represents benchmarks of the original code vs the dedup'd code (the binary
decode/encode leveraging the streaming implementations):

name                                        old time/op    new time/op    delta
RoundTrip/PrimitiveOptionalStruct/Encode-8    1.76µs ± 2%    1.86µs ± 5%    +5.93%  (p=0.008 n=5+5)
RoundTrip/PrimitiveOptionalStruct/Decode-8    2.55µs ± 3%    2.82µs ± 5%   +10.68%  (p=0.008 n=5+5)
RoundTrip/Graph/Encode-8                      3.15µs ± 2%    3.16µs ± 1%      ~     (p=1.000 n=5+5)
RoundTrip/Graph/Decode-8                      5.02µs ± 1%    8.95µs ±11%   +78.05%  (p=0.008 n=5+5)
RoundTrip/ContainersOfContainers/Encode-8     19.1µs ± 1%    19.8µs ± 3%    +3.76%  (p=0.008 n=5+5)
RoundTrip/ContainersOfContainers/Decode-8     45.2µs ± 3%   110.8µs ± 1%  +144.98%  (p=0.008 n=5+5)

name                                        old alloc/op   new alloc/op   delta
RoundTrip/PrimitiveOptionalStruct/Encode-8      704B ± 0%      704B ± 0%      ~     (all equal)
RoundTrip/PrimitiveOptionalStruct/Decode-8    1.40kB ± 0%    1.45kB ± 0%    +3.43%  (p=0.008 n=5+5)
RoundTrip/Graph/Encode-8                      1.70kB ± 0%    1.70kB ± 0%      ~     (all equal)
RoundTrip/Graph/Decode-8                      2.78kB ± 0%    3.55kB ± 0%   +27.98%  (p=0.008 n=5+5)
RoundTrip/ContainersOfContainers/Encode-8     1.30kB ± 0%    1.30kB ± 0%      ~     (all equal)
RoundTrip/ContainersOfContainers/Decode-8     12.3kB ± 0%    28.6kB ± 0%  +132.07%  (p=0.008 n=5+5)

name                                        old allocs/op  new allocs/op  delta
RoundTrip/PrimitiveOptionalStruct/Encode-8      1.00 ± 0%      1.00 ± 0%      ~     (all equal)
RoundTrip/PrimitiveOptionalStruct/Decode-8      14.0 ± 0%      15.0 ± 0%    +7.14%  (p=0.008 n=5+5)
RoundTrip/Graph/Encode-8                        11.0 ± 0%      11.0 ± 0%      ~     (all equal)
RoundTrip/Graph/Decode-8                        32.0 ± 0%      63.0 ± 0%   +96.88%  (p=0.008 n=5+5)
RoundTrip/ContainersOfContainers/Encode-8       18.0 ± 0%      18.0 ± 0%      ~     (all equal)
RoundTrip/ContainersOfContainers/Decode-8        164 ± 0%       837 ± 0%  +410.37%  (p=0.008 n=5+5)

and the original code vs the streaming implementations (benchmarks renamed for
the purpose of benchstat-ing).

name                                        old time/op    new time/op    delta
RoundTrip/PrimitiveOptionalStruct/Encode-8    1.76µs ± 2%    1.61µs ± 2%   -8.57%  (p=0.008 n=5+5)
RoundTrip/PrimitiveOptionalStruct/Decode-8    2.55µs ± 3%    1.19µs ± 0%  -53.36%  (p=0.008 n=5+5)
RoundTrip/Graph/Encode-8                      3.15µs ± 2%    1.88µs ± 1%  -40.29%  (p=0.008 n=5+5)
RoundTrip/Graph/Decode-8                      5.02µs ± 1%    1.87µs ± 2%  -62.76%  (p=0.008 n=5+5)
RoundTrip/ContainersOfContainers/Encode-8     19.1µs ± 1%    12.5µs ± 4%  -34.30%  (p=0.008 n=5+5)
RoundTrip/ContainersOfContainers/Decode-8     45.2µs ± 3%    27.6µs ± 1%  -38.90%  (p=0.008 n=5+5)

name                                        old alloc/op   new alloc/op   delta
RoundTrip/PrimitiveOptionalStruct/Encode-8      704B ± 0%       24B ± 0%  -96.59%  (p=0.008 n=5+5)
RoundTrip/PrimitiveOptionalStruct/Decode-8    1.40kB ± 0%    0.10kB ± 0%  -92.57%  (p=0.008 n=5+5)
RoundTrip/Graph/Encode-8                      1.70kB ± 0%    0.02kB ± 0%  -98.59%  (p=0.008 n=5+5)
RoundTrip/Graph/Decode-8                      2.78kB ± 0%    0.22kB ± 0%  -92.22%  (p=0.008 n=5+5)
RoundTrip/ContainersOfContainers/Encode-8     1.30kB ± 0%    0.02kB ± 0%  -98.16%  (p=0.008 n=5+5)
RoundTrip/ContainersOfContainers/Decode-8     12.3kB ± 0%    10.2kB ± 0%  -17.53%  (p=0.016 n=5+4)

name                                        old allocs/op  new allocs/op  delta
RoundTrip/PrimitiveOptionalStruct/Encode-8      1.00 ± 0%      1.00 ± 0%     ~     (all equal)
RoundTrip/PrimitiveOptionalStruct/Decode-8      14.0 ± 0%      11.0 ± 0%  -21.43%  (p=0.008 n=5+5)
RoundTrip/Graph/Encode-8                        11.0 ± 0%       1.0 ± 0%  -90.91%  (p=0.008 n=5+5)
RoundTrip/Graph/Decode-8                        32.0 ± 0%      11.0 ± 0%  -65.62%  (p=0.008 n=5+5)
RoundTrip/ContainersOfContainers/Encode-8       18.0 ± 0%       1.0 ± 0%  -94.44%  (p=0.008 n=5+5)
RoundTrip/ContainersOfContainers/Decode-8        164 ± 0%       146 ± 0%  -10.73%  (p=0.008 n=5+5)

witriew · 2021-06-16T05:27:09Z

A couple of things to the reviewers:

The cross-product testing probably needs a bit of modification to take in additional tests if needed (i.e., testing for equality to the original, which needs to be done after each combination).
The set/map/list generators need a check added to make sure that the type that's read is the type expected.

gen/list.go

gen/benchmark_test.go

gen/field.go

gen/list.go

gen/set.go

abhinav

Forgot to return on collection type mistmatch, but LGTM besides that

gen/list.go

gen/map.go

gen/set.go

abhinav · 2021-06-22T21:41:32Z

Also, check out gen/quick_test at some point. If we add another test to that test suite, it'll validate all generated types in the ThriftRW codebase.

gen/benchmark_test.go

mh-park · 2021-06-22T23:16:12Z

gen/container_test.go

 		assertRoundTrip(t, &tt.p, tt.v, tt.desc)
 		assert.True(t, tt.p.Equals(&tt.p), tt.desc)
+
+		testRoundTripCombos(t, &tt.p, tt.v, tt.desc)
+		assert.True(t, tt.p.Equals(&tt.p), tt.desc)


Doesn't testRoundTripCombos essentially include assertRoundTrip? From a brief look, it doesn't look like assertRoundTrip checks for anything more than testRoundTripCombos with false,false.

Yeah, we can remove that once all of this integration is done.

codecov · 2021-06-24T03:40:32Z

Codecov Report

Merging #496 (9888b65) into streamdev (a0a4391) will decrease coverage by 2.41%.
The diff coverage is 47.76%.

@@              Coverage Diff              @@
##           streamdev     #496      +/-   ##
=============================================
- Coverage      71.23%   68.81%   -2.42%     
=============================================
  Files            129      129              
  Lines          18693    22736    +4043     
=============================================
+ Hits           13316    15646    +2330     
- Misses          3711     4066     +355     
- Partials        1666     3024    +1358

Impacted Files	Coverage Δ
...en/internal/tests/non_hyphenated/non_hyphenated.go	`61.11% <15.38%> (+37.19%)`	⬆️
gen/internal/tests/services/services.go	`62.83% <38.47%> (-3.31%)`	⬇️
gen/internal/tests/exceptions/exceptions.go	`62.90% <39.43%> (-7.19%)`	⬇️
gen/internal/tests/containers/containers.go	`57.42% <39.47%> (-4.73%)`	⬇️
.../internal/tests/hyphenated-file/hyphenated-file.go	`63.21% <44.00%> (-6.14%)`	⬇️
.../internal/tests/hyphenated_file/hyphenated_file.go	`63.21% <44.00%> (-6.14%)`	⬇️
gen/internal/tests/structs/structs.go	`61.60% <44.76%> (-2.12%)`	⬇️
gen/internal/tests/collision/collision.go	`67.15% <45.33%> (-0.49%)`	⬇️
gen/internal/tests/nozap/nozap.go	`53.71% <46.03%> (+2.39%)`	⬆️
gen/internal/tests/set_to_slice/set_to_slice.go	`53.88% <47.46%> (-1.79%)`	⬇️
... and 32 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a0a4391...9888b65. Read the comment docs.

…ther types Provide the streaming read generators for all of the other types. Doing so meant providing a `StreamGenerator` that plumbs into the existing generators. This `StreamGenerator` only provides the "decoding" mechanism, leveraging #491 for reading the raw Thrift encoding off of the wire. In addition to providing a `StreamGenerator`, the list, map, set, enum, typdef, and struct generators all added a `Decoder` method that will appropriately recurse and iterate to generate the proper, mirrored readers for the raw wire representation. The `Decode` and `DecodePtr` methods for `StreamGenerator` then hook into the templated generator itself, providing the templated `decode` and `decodePtr` calls that will be used where necessary. The existing tests were leveraged to make sure that the streaming reads were compatible with the current binary writes and that no data was lost. In doing so, a 'genericized' function that will perform the cross-products of encoding/writing and decoding/reading. A benchmark was also added to evaluate the new streaming reads. ``` name \ time/op old.txt new.txt stream.txt RoundTrip/PrimitiveOptionalStruct/Encode-8 1.72µs ± 5% 1.72µs ± 0% 1.76µs ± 6% RoundTrip/PrimitiveOptionalStruct/Decode-8 2.47µs ± 1% 2.75µs ± 0% 2.68µs ± 1% RoundTrip/Graph/Encode-8 3.18µs ± 2% 3.13µs ± 1% 3.13µs ± 1% RoundTrip/Graph/Decode-8 5.02µs ± 2% 8.34µs ± 2% 8.35µs ± 2% RoundTrip/ContainersOfContainers/Encode-8 19.5µs ± 3% 19.0µs ± 2% 19.3µs ± 2% RoundTrip/ContainersOfContainers/Decode-8 46.8µs ± 5% 104.8µs ± 1% 106.7µs ± 2% RoundTrip/PrimitiveOptionalStruct/StreamingRead-8 1.09µs ± 1% RoundTrip/Graph/StreamingRead-8 1.69µs ± 4% RoundTrip/ContainersOfContainers/StreamingRead-8 25.3µs ± 2% name \ alloc/op old.txt new.txt stream.txt RoundTrip/PrimitiveOptionalStruct/Encode-8 704B ± 0% 704B ± 0% 704B ± 0% RoundTrip/PrimitiveOptionalStruct/Decode-8 1.40kB ± 0% 1.46kB ± 0% 1.46kB ± 0% RoundTrip/Graph/Encode-8 1.70kB ± 0% 1.70kB ± 0% 1.70kB ± 0% RoundTrip/Graph/Decode-8 2.78kB ± 0% 3.57kB ± 0% 3.57kB ± 0% RoundTrip/ContainersOfContainers/Encode-8 1.30kB ± 0% 1.30kB ± 0% 1.30kB ± 0% RoundTrip/ContainersOfContainers/Decode-8 12.3kB ± 0% 28.6kB ± 0% 28.6kB ± 0% RoundTrip/PrimitiveOptionalStruct/StreamingRead-8 104B ± 0% RoundTrip/Graph/StreamingRead-8 216B ± 0% RoundTrip/ContainersOfContainers/StreamingRead-8 10.2kB ± 0% name \ allocs/op old.txt new.txt stream.txt RoundTrip/PrimitiveOptionalStruct/Encode-8 1.00 ± 0% 1.00 ± 0% 1.00 ± 0% RoundTrip/PrimitiveOptionalStruct/Decode-8 14.0 ± 0% 15.0 ± 0% 15.0 ± 0% RoundTrip/Graph/Encode-8 11.0 ± 0% 11.0 ± 0% 11.0 ± 0% RoundTrip/Graph/Decode-8 32.0 ± 0% 63.0 ± 0% 63.0 ± 0% RoundTrip/ContainersOfContainers/Encode-8 18.0 ± 0% 18.0 ± 0% 18.0 ± 0% RoundTrip/ContainersOfContainers/Decode-8 164 ± 0% 837 ± 0% 837 ± 0% RoundTrip/PrimitiveOptionalStruct/StreamingRead-8 11.0 ± 0% RoundTrip/Graph/StreamingRead-8 11.0 ± 0% RoundTrip/ContainersOfContainers/StreamingRead-8 147 ± 0% ``` "old" represents the original code, "new" represents the binary decoding utilizing the streaming decoder, and "stream" represents the benchmarks as it stands at this diff.

dianale31 · 2021-06-24T05:46:44Z

gen/enum.go

@@ -53,6 +53,29 @@ func (e *enumGenerator) Reader(g Generator, spec *compile.EnumSpec) (string, err
 	return name, wrapGenerateError(spec.ThriftName(), err)
 }

+func (e *enumGenerator) Decoder(g Generator, spec *compile.EnumSpec) (string, error) {


Be consistent with calling the function "Decode" like you've done with the fieldGenerator.

gen/list.go

gen/quick_test.go

dianale31 · 2021-06-24T05:54:31Z

LGTM!

abhinav

!!

# Commits The following comments are included in this release. Some of these cherry-picked and released in v1.28.0, but they appear again in the list above. - protocol: Add streaming interfaces (#485) - Move Stream-based interfaces into their own package - Make Streaming interfaces private to allow for safe experimentation (#488) - idl: Return structured ParseError from idl.Parse() (#492) - Add CHANGELOG entry for #492 (#494) - Support "<" in the templating language (#499) - idl: add a Position struct to wrap reported lines (#497) - Add streamwriter implementation (#490) - Add a "StreamReader" which implements "stream.Reader" - Use the "stream.Reader" in the "binary.Reader" - Add code generation for all wire types for stream encoding (#500) - Generate "Decode" for "enums" that will directly decode (#495) - Provide "decode" code generation for the streaming variants for all other types (#496) - idl: record document positions on constant nodes (#503) - ast: move idl.Position to the ast package (#504) - idl: replace internal.Position with ast.Position (#505) - Expose stream protocol method to close Writer (#506) - idl: add column numbers to parse error positions (#507) - idl: record full positions for constants (#508) - Mark assertParseCases() as a test helper (#509) - protocol/stream: Define enveloping interfaces (#511) - protocol/stream: Declare interface for encoding envelopes (#513) - binary/StreamWriter: Borrow => New; unexport Return (#515) - stream: add Close method, pool binary reader (#514) - binary/reader: Return to pool after ReadValue (#517) - binary/reader: Skip fixed width collections faster (#518) - binary/stream/reader: Fast-path offsetReader skips (#519) - binary: Move Responders and Protocol into package (#516) - benchmark: Refactor into a suite (#520) - Upgrade to Ragel version 6.10 (from 6.9) (#523) - Responder: Deduplicate interface (#524) - gen/quick_test: Add missing types (#525) - enum/json: Support rejecting unknown values (#502) - Back to development - Upgrade to golang.org/x/tools version 0.1.5 (#529) - ast: add column values to the AST nodes (#522) - stream: Implement Request and Response handling with Enveloping (#526) - offsetReader: Implement io.Seeker - binary/ReadRequest: Use io.Seeker if available - StreamReader: Use Seeker instead of offsetReader - protocol/stream: Unembed stream.Protocol from stream.RequestReader (#532) - thrifttest: Add mocks for streaming interfaces (#527) - streaming: Unembed iface.Private in streaming-based interfaces (#533) - Regenerate files for tests after merging `streamdev` - ast: formally declare CppInclude as a Node (#536) - ast: add Annotations(Node) []*Annotations (#537) - Preparing release v1.29.0 # API changes I ran apidiff on all packages in v1.28.0 and compared it with this release. Removing changes to gen/internal/tests, the result is: ``` --- go.uber.org/thriftrw/ast --- Compatible changes: - Annotation.Column: added - Annotations: added - BaseType.Column: added - Constant.Column: added - ConstantList.Column: added - ConstantMap.Column: added - ConstantMapItem.Column: added - ConstantReference.Column: added - CppInclude.Column: added - DefinitionInfo.Column: added - Enum.Column: added - EnumItem.Column: added - Field.Column: added - Function.Column: added - Include.Column: added - ListType.Column: added - MapType.Column: added - Namespace.Column: added - Position.Column: added - Position.String: added - Service.Column: added - ServiceReference.Column: added - SetType.Column: added - Struct.Column: added - TypeReference.Column: added - Typedef.Column: added --- go.uber.org/thriftrw/envelope/stream --- NEW PACKAGE --- go.uber.org/thriftrw/gen --- Compatible changes: - StreamGenerator: added --- go.uber.org/thriftrw/internal/envelope/exception --- Compatible changes: - (*ExceptionType).Decode: added - (*TApplicationException).Decode: added - (*TApplicationException).Encode: added - ExceptionType.Encode: added --- go.uber.org/thriftrw/plugin/api --- Compatible changes: - (*Argument).Decode: added - (*Argument).Encode: added - (*Feature).Decode: added - (*Function).Decode: added - (*Function).Encode: added - (*GenerateServiceRequest).Decode: added - (*GenerateServiceRequest).Encode: added - (*GenerateServiceResponse).Decode: added - (*GenerateServiceResponse).Encode: added - (*HandshakeRequest).Decode: added - (*HandshakeRequest).Encode: added - (*HandshakeResponse).Decode: added - (*HandshakeResponse).Encode: added - (*Module).Decode: added - (*Module).Encode: added - (*ModuleID).Decode: added - (*Plugin_Goodbye_Args).Decode: added - (*Plugin_Goodbye_Args).Encode: added - (*Plugin_Goodbye_Result).Decode: added - (*Plugin_Goodbye_Result).Encode: added - (*Plugin_Handshake_Args).Decode: added - (*Plugin_Handshake_Args).Encode: added - (*Plugin_Handshake_Result).Decode: added - (*Plugin_Handshake_Result).Encode: added - (*Service).Decode: added - (*Service).Encode: added - (*ServiceGenerator_Generate_Args).Decode: added - (*ServiceGenerator_Generate_Args).Encode: added - (*ServiceGenerator_Generate_Result).Decode: added - (*ServiceGenerator_Generate_Result).Encode: added - (*ServiceID).Decode: added - (*SimpleType).Decode: added - (*Type).Decode: added - (*Type).Encode: added - (*TypePair).Decode: added - (*TypePair).Encode: added - (*TypeReference).Decode: added - (*TypeReference).Encode: added - Feature.Encode: added - ModuleID.Encode: added - ServiceID.Encode: added - SimpleType.Encode: added --- go.uber.org/thriftrw/protocol --- Compatible changes: - BinaryStreamer: added --- go.uber.org/thriftrw/protocol/binary --- Compatible changes: - Default: added - EnvelopeV0Responder: added - EnvelopeV1Responder: added - NewStreamReader: added - NewStreamWriter: added - NoEnvelopeResponder: added - Protocol: added - Responder: added - StreamReader: added - StreamWriter: added --- go.uber.org/thriftrw/protocol/envelope --- NEW PACKAGE --- go.uber.org/thriftrw/protocol/stream --- NEW PACKAGE --- go.uber.org/thriftrw/thrifttest/streamtest --- NEW PACKAGE --- go.uber.org/thriftrw/version --- Incompatible changes: - Version: value changed from "1.28.0" to "1.29.0" ```

witriew requested review from abhinav, dianale31 and r-hang June 16, 2021 05:18

witriew commented Jun 16, 2021

View reviewed changes

gen/list.go Outdated Show resolved Hide resolved

witriew changed the title ~~Provide generators for the streaming variants for all other types~~ Provide "decode" code generation for the streaming variants for all other types Jun 16, 2021

dianale31 mentioned this pull request Jun 16, 2021

Add code generation for all wire types for stream encoding #498

Closed

witriew force-pushed the witriew/sreader_gen_enums branch from bf5fa66 to a7893a9 Compare June 16, 2021 21:38

witriew force-pushed the witriew/gen_everything branch from 1da7f69 to 6fa1b7c Compare June 16, 2021 21:40

witriew requested a review from mh-park June 17, 2021 00:35

dianale31 mentioned this pull request Jun 22, 2021

Add code generation for all wire types for stream encoding #500

Merged

dianale31 reviewed Jun 22, 2021

View reviewed changes

gen/benchmark_test.go Outdated Show resolved Hide resolved

dianale31 reviewed Jun 22, 2021

View reviewed changes

gen/field.go Outdated Show resolved Hide resolved

dianale31 reviewed Jun 22, 2021

View reviewed changes

gen/list.go Outdated Show resolved Hide resolved

dianale31 reviewed Jun 22, 2021

View reviewed changes

gen/set.go Outdated Show resolved Hide resolved

witriew force-pushed the witriew/sreader_gen_enums branch 2 times, most recently from bc1e0ce to 80aca24 Compare June 22, 2021 19:53

witriew force-pushed the witriew/gen_everything branch from 6fa1b7c to 9042ba6 Compare June 22, 2021 20:08

abhinav reviewed Jun 22, 2021

View reviewed changes

gen/list.go Outdated Show resolved Hide resolved

gen/map.go Outdated Show resolved Hide resolved

gen/set.go Outdated Show resolved Hide resolved

witriew force-pushed the witriew/sreader_gen_enums branch from 80aca24 to f9f98e7 Compare June 22, 2021 21:45

mh-park reviewed Jun 22, 2021

View reviewed changes

witriew force-pushed the witriew/sreader_gen_enums branch 2 times, most recently from f467573 to 0d5251b Compare June 23, 2021 20:43

Base automatically changed from witriew/sreader_gen_enums to streamdev June 23, 2021 20:47

witriew force-pushed the witriew/gen_everything branch 2 times, most recently from 0053ede to 91f4e59 Compare June 24, 2021 03:38

witriew requested review from abhinav and dianale31 June 24, 2021 05:07

witriew requested a review from mh-park June 24, 2021 05:07

witriew added 3 commits June 24, 2021 00:12

Add test to quick_test

db9b5b6

Cover more structs - non-hyphenated First and Second

eb8268c

dianale31 reviewed Jun 24, 2021

View reviewed changes

gen/list.go Show resolved Hide resolved

dianale31 reviewed Jun 24, 2021

View reviewed changes

gen/quick_test.go Show resolved Hide resolved

abhinav approved these changes Jun 24, 2021

View reviewed changes

Review comments

9888b65

witriew force-pushed the witriew/gen_everything branch from 642d2be to 9888b65 Compare June 25, 2021 00:09

witriew merged commit 766cbfa into streamdev Jun 25, 2021

witriew deleted the witriew/gen_everything branch June 25, 2021 00:15

abhinav mentioned this pull request Aug 30, 2021

Release v1.29.0 #539

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Provide "decode" code generation for the streaming variants for all other types #496

Provide "decode" code generation for the streaming variants for all other types #496

witriew commented Jun 16, 2021 •

edited

Loading

witriew commented Jun 16, 2021

abhinav left a comment

abhinav commented Jun 22, 2021

mh-park Jun 22, 2021

witriew Jun 23, 2021

codecov bot commented Jun 24, 2021 •

edited

Loading

dianale31 Jun 24, 2021

dianale31 commented Jun 24, 2021

abhinav left a comment

Provide "decode" code generation for the streaming variants for all other types #496

Provide "decode" code generation for the streaming variants for all other types #496

Conversation

witriew commented Jun 16, 2021 • edited Loading

witriew commented Jun 16, 2021

abhinav left a comment

Choose a reason for hiding this comment

abhinav commented Jun 22, 2021

mh-park Jun 22, 2021

Choose a reason for hiding this comment

witriew Jun 23, 2021

Choose a reason for hiding this comment

codecov bot commented Jun 24, 2021 • edited Loading

Codecov Report

dianale31 Jun 24, 2021

Choose a reason for hiding this comment

dianale31 commented Jun 24, 2021

abhinav left a comment

Choose a reason for hiding this comment

witriew commented Jun 16, 2021 •

edited

Loading

codecov bot commented Jun 24, 2021 •

edited

Loading