-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sharing to Facebook etc doesn't share correct image #18
Comments
fix: in wp-content/plugins/photoswipe-masonry/photoswipe-dist/photoswipe-ui-default.min.js Caveats:
|
(this doesn't solve the problem for twitter of course, which doesn't seem to accept a url parameter to override the twitter card, I would just remove the twitter sharing option) |
further fix, even better is to add the description of the current image rather than just using the description of the page: small separate issue, photoswipe isn't trying hard enough to get the description, as I have commented further on thriveweb/photoswipe-masonry#2 |
This should be addressed in Photoswipe source but isn't yet, refer to dimsemenov/PhotoSwipe#749 |
Fixes thriveweb#18 by: - adding current image url and caption to Facebook sharing link - hiding twitter link since not fixable via this method
Fixes thriveweb#18 by: - adding current image url and caption to Facebook sharing link - hiding twitter link since not fixable via this method applying same to minified and unminified file
Fixes thriveweb#18 by adding current image to Facebook link
Patch 1 Fixes #18 by adding current image to Facebook link
Sharing to Facebook etc doesn't share correct image.
When paging through a picture gallery, the code does not change the page level meta attributes.
This means that facebook gets the original page image (eg the WordPress Featured image) from the meta and not the image the user is trying to share.
To fix this, these types of properties need to be reset:
This might need to be done on the server, the add-in would need to set the featured image based on the &gid=psgal_280_2&pid=1 query string, since when facebook etc calls the site looking for the image for the post it's probably going for the meta directly without triggering the javascript.
thoughts?
While this doesn't work, the sharing should perhaps be disabled...
The text was updated successfully, but these errors were encountered: