Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Save passwords #202

Closed
thsmi opened this issue Mar 7, 2020 · 1 comment · Fixed by #259
Closed

Save passwords #202

thsmi opened this issue Mar 7, 2020 · 1 comment · Fixed by #259
Assignees
@thsmi
Labels
App Issue affects the standalone application enhancement
Milestone
0.5

Comments

@thsmi
Copy link
Owner

thsmi commented Mar 7, 2020 •
edited
Loading

Electron does not offer a password manager. Thus we need a password manager implementation to store passwords safely.

e.g. https://github.com/atom/node-keytar from the atom editor would be an options. It uses the operating systems default wallet, so that passwords can be automatically synced between accounts.
@thsmi thsmi changed the title Save password/master password Save password password Mar 7, 2020
@thsmi thsmi added App Issue affects the standalone application enhancement labels Mar 7, 2020
@thsmi thsmi added this to the Future milestone Mar 7, 2020
@thsmi thsmi mentioned this issue Mar 7, 2020
Closed
@thsmi thsmi modified the milestones: Future, 0.5 Apr 10, 2020
@thsmi thsmi mentioned this issue Apr 10, 2020
Open
2 tasks
@thsmi thsmi changed the title Save password password Save passwords Apr 19, 2020
thsmi added a commit that referenced this issue Apr 24, 2020
@thsmi
Packaging keytar prebuilts
6da9997 
#202
thsmi added a commit that referenced this issue Apr 25, 2020
@thsmi
Use manifest from output folder when repackging prebuilts
b1a3808 
* When repackaging prebuilts only the manifest in the output folder should be used.
* Linux and Mac Build did not cache artifact correctly

#202
thsmi added a commit that referenced this issue Apr 25, 2020
@thsmi
Implement ui for keystore
7457abb 
* Add remember to password dialog.
* Add forget password to credentials dialog.
* Use password from keystore when available.

closes #202
@thsmi thsmi linked a pull request Apr 25, 2020 that will close this issue
Keytar #259
Merged
@thsmi thsmi closed this as completed Apr 25, 2020
thsmi added a commit that referenced this issue Apr 25, 2020
@thsmi
Keytar (#259)
185593a 
* Packaging keytar prebuilts

#202

* Use manifest from output folder when repackging prebuilts

* When repackaging prebuilts only the manifest in the output folder should be used.
* Linux and Mac Build did not cache artifact correctly

#202

* Implement ui for keystore

* Add remember to password dialog.
* Add forget password to credentials dialog.
* Use password from keystore when available.

closes #202
@thsmi thsmi self-assigned this Apr 25, 2020
@Jorilx
Copy link

Jorilx commented May 7, 2024

@thsmi I'm sorry, is this supposed to work on Debian/Mate? I'm using the standalone app on Debian 10

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@thsmi thsmi

Labels
App Issue affects the standalone application enhancement
Projects
None yet
Milestone
0.5
Development

Successfully merging a pull request may close this issue.

Keytar thsmi/sieve
2 participants
@Jorilx @thsmi