-
-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for vnd.dovecot.pgp-encrypt #658
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you very much for contributing.
Did a rough check, everything looks good but have not tested it yet. I'll try to do that in the next days. So that this can land soon on the master. I'll also try to do a quick release afterwards.
While reviewing I stumbled upon the following "non technical" glitches:
The original author in the license header is pointing to me. But you did the work so you should add you as the initial author to all the files you created newly. If the file exists then you need to add yourself as an additional author.
Translations are auto generated as soon as it lands in the master. All you need to do is to add the new strings only to the en-us json file. Otherwise crowding gets confused and runs into conflicts which need to be manually resolved. I'll add a readme note to the folder containing the translations.
Thank you for your response! Please have a look at the last changes as I am not really familiar with this project and its best practices. I also updated the author in the license headers and removed the i18n strings in other languages than en-us. |
Where would i find the dovecot side of this PR and its documentation? |
Unfortunately I could not find documentation or source code for the extension. |
According to mailbox.org, no public documentation for this plugin is available. |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
Sorry completely forgot about this pull request. |
Added (rudimentary) support for the vnd.dovecot.pgp-encrypt sieve filter.