Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Info not passed to actor of PGPolicy #775

Closed
RuihangWang opened this issue Nov 19, 2022 · 2 comments · Fixed by #787
Closed

Info not passed to actor of PGPolicy #775

RuihangWang opened this issue Nov 19, 2022 · 2 comments · Fixed by #787
Labels
bug Something isn't working

Comments

@RuihangWang
Copy link

version 0.4.10

  • Line 108, only two parameters passed into the actor forward, the info dictionary is missing
@janofsun
Copy link
Contributor

Do you mean passing **kwargs to actor? But I don't think it's necessary to do that

@Trinkle23897 Trinkle23897 added the bug Something isn't working label Dec 24, 2022
@Trinkle23897
Copy link
Collaborator

Thanks for the report, I'll open a PR accordingly.

@Trinkle23897 Trinkle23897 mentioned this issue Dec 24, 2022
Merged
Trinkle23897 added a commit that referenced this issue Dec 24, 2022
@Trinkle23897
fix info not pass issue in PGPolicy (#787)
1037627 
close #775
BFAnas pushed a commit to BFAnas/tianshou that referenced this issue May 5, 2024
@Trinkle23897
fix info not pass issue in PGPolicy (thu-ml#787)
35bee40 
close thu-ml#775
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix info not pass issue in PGPolicy Trinkle23897/tianshou
3 participants
@Trinkle23897 @RuihangWang @janofsun