Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use explicit multiprocessing context for creating Pipe in subproc.py #1102

Merged

Conversation

maxhuettenrauch
Copy link
Collaborator

  • I have added the correct label(s) to this Pull Request or linked the relevant issue(s)
  • I have provided a description of the changes in this Pull Request
  • I have added documentation for my changes
  • If applicable, I have added tests to cover my changes.
  • I have reformatted the code using poe format
  • I have checked style and types with poe lint and poe type-check
  • (Optional) I ran tests locally with poe test
    (or a subset of them with poe test-reduced) ,and they pass
  • (Optional) I have tested that documentation builds correctly with poe doc-build

Not sure why it worked before (or whether it shouldn't have worked), but this seems more consistent...

@MischaPanch
Copy link
Collaborator

Is this ready for merge? It's still in draft status

Was a test missing that would have caught this?

@maxhuettenrauch maxhuettenrauch marked this pull request as ready for review April 19, 2024 07:28
@maxhuettenrauch
Copy link
Collaborator Author

Not sure about tests, I'm no multiprocessing expert. All the examples were running, though

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.20%. Comparing base (ca4f74f) to head (a4b6bb4).
Report is 2 commits behind head on master.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1102      +/-   ##
==========================================
- Coverage   88.22%   88.20%   -0.03%     
==========================================
  Files         100      100              
  Lines        8331     8340       +9     
==========================================
+ Hits         7350     7356       +6     
- Misses        981      984       +3     
Flag Coverage Δ
unittests 88.20% <100.00%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@MischaPanch MischaPanch merged commit 9c0b3e7 into thu-ml:master Apr 19, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants