Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Policy parameter action_scaling was not correctly transformed (high-level API) #1191

Merged
merged 1 commit into from
Aug 7, 2024

Conversation

opcode81
Copy link
Collaborator

@opcode81 opcode81 commented Aug 7, 2024

Policy parameter action_scaling value "default" was not correctly transformed to a Boolean value for algorithms SAC, DDPG, TD3 and REDQ. The value "default" being truthy caused action scaling to be enabled even for discrete action spaces.

  • I have added the correct label(s) to this Pull Request or linked the relevant issue(s)
  • I have provided a description of the changes in this Pull Request
  • I have added documentation for my changes and have listed relevant changes in CHANGELOG.md
  • If applicable, I have added tests to cover my changes.
  • I have reformatted the code using poe format
  • I have checked style and types with poe lint and poe type-check
  • (Optional) I ran tests locally with poe test
    (or a subset of them with poe test-reduced) ,and they pass
  • (Optional) I have tested that documentation builds correctly with poe doc-build

@opcode81 opcode81 added bug Something isn't working high-level-api Mainly affects tianshou.highlevel labels Aug 7, 2024
@opcode81 opcode81 force-pushed the fix/hl-action-scaling branch from ad5d411 to 480992d Compare August 7, 2024 08:41
@opcode81 opcode81 force-pushed the fix/hl-action-scaling branch from 480992d to 8daba10 Compare August 7, 2024 08:44
@MischaPanch MischaPanch enabled auto-merge (squash) August 7, 2024 08:50
@MischaPanch MischaPanch disabled auto-merge August 7, 2024 08:50
@MischaPanch MischaPanch merged commit fb0561a into master Aug 7, 2024
1 of 4 checks passed
@MischaPanch MischaPanch deleted the fix/hl-action-scaling branch August 7, 2024 08:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working high-level-api Mainly affects tianshou.highlevel
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants