Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix venv seed, add TOC in docs, and split buffer.py into several files #303

Merged
merged 4 commits into from
Mar 2, 2021
Merged

fix venv seed, add TOC in docs, and split buffer.py into several files #303

merged 4 commits into from
Mar 2, 2021

Conversation

Trinkle23897
Copy link
Collaborator

patch for #299

@Trinkle23897 Trinkle23897 changed the title fix venv seed fix venv seed, add TOC in docs, and split buffer.py into several files Mar 2, 2021
@Trinkle23897
Copy link
Collaborator Author

Trinkle23897 commented Mar 2, 2021 •
edited by ChenDRAG
Loading

2021-03-01 22-48-30 的屏幕截图

  • Hyperlink doesn't work well
  • E.g. [s_{t-3}, s_{t-2}, s_{t-1}, s_t], where s is self.key, t is the index. This is unclear.
  • other types of buffer should mention "APIs are the same as ReplayBuffer"
  • move collector's example usage to docs/concepts.rst
  • modify trainer's __init__ order
  • split buffer and collector into several files
  • policy docs need a TOC
  • venv.action_space should set seed in venv.seed(), keep a copy in local worker space

@Trinkle23897 Trinkle23897 linked an issue Mar 2, 2021 that may be closed by this pull request
action_space in SubprocVectorEnv make it harder to reproduce result. #299
Closed
@Trinkle23897 Trinkle23897 requested a review from ChenDRAG March 2, 2021 01:46
@Trinkle23897 Trinkle23897 merged commit 454c86c into thu-ml:dev Mar 2, 2021
@Trinkle23897 Trinkle23897 deleted the venv-seed branch March 2, 2021 04:28
BFAnas pushed a commit to BFAnas/tianshou that referenced this pull request May 5, 2024
@Trinkle23897
fix venv seed, add TOC in docs, and split buffer.py into several files (
09775bd 
thu-ml#303)

Things changed in this PR:

- various docs update, add TOC
- split buffer into several files
- fix venv action_space randomness
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChenDRAG ChenDRAG ChenDRAG approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

action_space in SubprocVectorEnv make it harder to reproduce result.
2 participants
@Trinkle23897 @ChenDRAG