-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remap action to fit gym's action space #313
Conversation
The validity of this implementation is verified by my version of PPO as stated in #307. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is the action of SAC mapped in forward
and then mapped again in map_action
?
just once, the code in forward is to correct the log_prob for entropy term |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
great job
Codecov Report
@@ Coverage Diff @@
## master #313 +/- ##
==========================================
+ Coverage 93.91% 93.92% +0.01%
==========================================
Files 51 51
Lines 3270 3278 +8
==========================================
+ Hits 3071 3079 +8
Misses 199 199
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Co-authored-by: Trinkle23897 <trinkle23897@gmail.com>
See #312 for details.