Refactor PG algorithm and change behavior of compute_episodic_return
#319
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Trinkle23897
approved these changes
Mar 23, 2021
BFAnas
pushed a commit
to BFAnas/tianshou
that referenced
this pull request
May 5, 2024
thu-ml#319) - simplify code - apply value normalization (global) and adv norm (per-batch) in on-policy algorithms
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #307 , #317 for details. Note that I remove 'rew_norm' option from compute_episodic_return() because latter I will redefine how to do value normalization(different algorithm may need different rew_norm schedule?)