Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix atari_bcq #345

Merged
merged 4 commits into from
Apr 20, 2021
Merged

fix atari_bcq #345

merged 4 commits into from
Apr 20, 2021

Conversation

Trinkle23897
Copy link
Collaborator

@Trinkle23897 Trinkle23897 requested a review from ChenDRAG April 20, 2021 08:07
@codecov-commenter
Copy link

codecov-commenter commented Apr 20, 2021

Codecov Report

Merging #345 (54f7fea) into master (a57503c) will decrease coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #345      +/-   ##
==========================================
- Coverage   94.22%   94.19%   -0.03%     
==========================================
  Files          52       52              
  Lines        3362     3362              
==========================================
- Hits         3168     3167       -1     
- Misses        194      195       +1     
Flag Coverage Δ
unittests 94.19% <ø> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
tianshou/policy/imitation/discrete_bcq.py 98.24% <ø> (ø)
tianshou/trainer/onpolicy.py 95.58% <0.00%> (-1.48%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a57503c...54f7fea. Read the comment docs.

@Trinkle23897 Trinkle23897 merged commit c059f98 into thu-ml:master Apr 20, 2021
@Trinkle23897 Trinkle23897 deleted the bcq-fix branch April 20, 2021 14:59
BFAnas pushed a commit to BFAnas/tianshou that referenced this pull request May 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants