fix tqdm issue #481
Merged
fix tqdm issue #481
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #481 +/- ##
=======================================
Coverage 94.04% 94.04%
=======================================
Files 60 60
Lines 3910 3910
=======================================
Hits 3677 3677
Misses 233 233
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
thkkk
reviewed
Nov 18, 2021
| @@ -117,8 +117,8 @@ def offpolicy_trainer( | |||
| env_step += int(result["n/st"]) | |||
| t.update(result["n/st"]) | |||
| logger.log_train_data(result, env_step) | |||
| last_rew = result['rew'] if 'rew' in result else last_rew | |||
| last_len = result['len'] if 'len' in result else last_len | |||
| last_rew = result['rew'] if result["n/ep"] > 0 else last_rew | |||
There was a problem hiding this comment.
result["n/ep"] corresponds to episode_count in collector.py. If episode_count > 0, then the 'rew' and 'len' must exist.
thkkk
approved these changes
Nov 18, 2021
BFAnas
pushed a commit
to BFAnas/tianshou
that referenced
this pull request
May 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#459 introduces a bug where the progress bar cannot show the last episode reward/length correctly, this PR fix that issue.