Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Wandblogger import error #562

Merged
merged 3 commits into from
Mar 8, 2022
Merged

Fix Wandblogger import error #562

merged 3 commits into from
Mar 8, 2022

Conversation

gogoduan
Copy link
Contributor

@gogoduan gogoduan commented Mar 8, 2022

  • I have marked all applicable categories:
    • exception-raising fix
    • algorithm implementation fix
    • documentation modification
    • new feature
  • I have reformatted the code using make format (required)
  • I have checked the code using make commit-checks (required)
  • If applicable, I have mentioned the relevant/related issue(s)
  • If applicable, I have listed every items in this Pull Request below

@codecov-commenter
Copy link

codecov-commenter commented Mar 8, 2022

Codecov Report

Merging #562 (9fee0b9) into master (df3d7f5) will decrease coverage by 0.06%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #562      +/-   ##
==========================================
- Coverage   93.85%   93.78%   -0.07%     
==========================================
  Files          64       64              
  Lines        4376     4376              
==========================================
- Hits         4107     4104       -3     
- Misses        269      272       +3     
Flag Coverage Δ
unittests 93.78% <ø> (-0.07%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
tianshou/policy/modelfree/trpo.py 88.52% <0.00%> (-4.92%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update df3d7f5...9fee0b9. Read the comment docs.

@Trinkle23897 Trinkle23897 merged commit 1e43562 into thu-ml:master Mar 8, 2022
BFAnas pushed a commit to BFAnas/tianshou that referenced this pull request May 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants