Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add write_flush in tflogger, fix argument passing in wandblogger #581

Merged
merged 2 commits into from
Mar 30, 2022

Conversation

Trinkle23897
Copy link
Collaborator

close #580

Comment on lines +81 to +84
self.tensorboard_logger = TensorboardLogger(
writer, self.train_interval, self.test_interval, self.update_interval,
self.save_interval, self.write_flush
)
Copy link
Collaborator Author

@Trinkle23897 Trinkle23897 Mar 29, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vwxyzjn this is a bug fix #558

@codecov-commenter
Copy link

Codecov Report

Merging #581 (03e932b) into master (6ab9860) will decrease coverage by 0.06%.
The diff coverage is 100.00%.

❗ Current head 03e932b differs from pull request most recent head 7f9e973. Consider uploading reports for the commit 7f9e973 to get more accurate results

@@            Coverage Diff             @@
##           master     #581      +/-   ##
==========================================
- Coverage   93.51%   93.45%   -0.07%     
==========================================
  Files          66       66              
  Lines        4429     4429              
==========================================
- Hits         4142     4139       -3     
- Misses        287      290       +3     
Flag Coverage Δ
unittests 93.45% <100.00%> (-0.07%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
tianshou/utils/logger/tensorboard.py 75.00% <100.00%> (+1.19%) ⬆️
tianshou/utils/logger/wandb.py 52.83% <100.00%> (+0.90%) ⬆️
tianshou/policy/modelfree/trpo.py 88.52% <0.00%> (-4.92%) ⬇️
tianshou/data/collector.py 93.77% <0.00%> (-0.05%) ⬇️
tianshou/env/worker/subproc.py 94.03% <0.00%> (-0.04%) ⬇️

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@Trinkle23897 Trinkle23897 merged commit f13e415 into thu-ml:master Mar 30, 2022
@Trinkle23897 Trinkle23897 deleted the write-flush branch March 30, 2022 00:04
BFAnas pushed a commit to BFAnas/tianshou that referenced this pull request May 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make flush() optional in Tensoboard logger write() method
2 participants