Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

action_dim -> action_shape #602

Merged
merged 1 commit into from
Apr 22, 2022
Merged

action_dim -> action_shape #602

merged 1 commit into from
Apr 22, 2022

Conversation

Squeemos
Copy link
Contributor

Noticed that in IQN and FQF there were some mismatches in the docstrings. Figured I would make a pull request to make it match. Causes an exception if using kwargs over args.

  • I have marked all applicable categories:
    • exception-raising fix
    • algorithm implementation fix
    • documentation modification
    • new feature
  • I have reformatted the code using make format (required)
  • I have checked the code using make commit-checks (required)
  • If applicable, I have mentioned the relevant/related issue(s)
  • If applicable, I have listed every items in this Pull Request below

Noticed that in IQN and FQF there were some mismatches in the docstrings. Figured I would make a pull request to make it match.
@codecov-commenter
Copy link

codecov-commenter commented Apr 20, 2022

Codecov Report

Merging #602 (d1b54b7) into master (57ecebd) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #602   +/-   ##
=======================================
  Coverage   93.54%   93.54%           
=======================================
  Files          67       67           
  Lines        4433     4433           
=======================================
  Hits         4147     4147           
  Misses        286      286           
Flag Coverage Δ
unittests 93.54% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
tianshou/utils/net/discrete.py 100.00% <ø> (ø)

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@Trinkle23897 Trinkle23897 requested a review from nuance1979 April 20, 2022 13:21
Copy link
Collaborator

@nuance1979 nuance1979 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Trinkle23897 Trinkle23897 merged commit e01385e into thu-ml:master Apr 22, 2022
@Squeemos Squeemos deleted the patch-2 branch April 22, 2022 01:37
BFAnas pushed a commit to BFAnas/tianshou that referenced this pull request May 5, 2024
Noticed that in IQN and FQF there were some mismatches in the docstrings. Figured I would make a pull request to make it match.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants