Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

removed gym as a dev dependency #813

Closed
wants to merge 1 commit into from
Closed

Conversation

zbenmo
Copy link
Contributor

@zbenmo zbenmo commented Feb 27, 2023

  • I have marked all applicable categories:
    • exception-raising fix
    • algorithm implementation fix
    • documentation modification
    • new feature
  • I have reformatted the code using make format (required)
  • I have checked the code using make commit-checks (required)
  • If applicable, I have mentioned the relevant/related issue(s)
  • If applicable, I have listed every items in this Pull Request below

@nuance1979
Copy link
Collaborator

Why do you need to remove gym? We keep gym in dev in order to test backward compatibility through shimmy.

@zbenmo
Copy link
Contributor Author

zbenmo commented Feb 28, 2023 via email

@nuance1979
Copy link
Collaborator

The gym dependency is replaced with gymnasium in #789 , specifically here. Tianshou's next release should not have gym dependency unless [dev] is used.

Until the next release, you can either remove gym manually or install Tianshou's master branch.

@nuance1979 nuance1979 closed this Feb 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants