-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add multiprocess support #16
Add multiprocess support #16
Conversation
@savar @mbarouski Hello! Can you check it please? |
Hey, I am not experienced in this multiprocess part of the prometheus client. Also as far as I can tell the multiprocess would require a properly set Do you have a working example deployment where this is being used, so that we could have a better look onto it? |
It looks like it could work but we will lose the I just cannot figure out how we could detect the multiprocess situation. Thumbor is not providing this information in the config it passes into the initializer and relying on the environment variable would only mean that people do not realize that they didn't configure it correctly. 🤔 |
Maybe only use |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's try it like that. I am still not 100% sure that it always works perfectly but it looks like it can. But without the environment variable it won't work, so not doing it without it.
I will change some more stuff and add some documentation when this is merged.
Co-authored-by: Simon Effenberg <savar@schuldeigen.de>
Co-authored-by: Simon Effenberg <savar@schuldeigen.de>
relates to #15