-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Thumbor redis storage #54
Conversation
Hey @guilhermef , maybe we can use Redis client from |
Hey @RaphaelVRossi, we're using an async Redis client for the storage. Maybe we can the async one on both. |
@RaphaelVRossi there's also another issue. |
Pull Request Test Coverage Report for Build 3355783961
💛 - Coveralls |
Pull Request Test Coverage Report for Build 3379931166
💛 - Coveralls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good. Please consider my suggestions/nits below.
Code Climate has analyzed commit b255ba5 and detected 0 issues on this pull request. View more on Code Climate. |
Thanks @scorphus |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks @guilhermef 🥳
This storage should be used when using Queued detector on Thumbor