adding serverside encryption #242
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Since it can be two separate buckets, this would have to be configured twice |
|
I'm not a python developer, is there anything else I can do to get it upstream? |
|
@pschrammel, just testing the feature that you're adding, and making sure that the tests are green |
|
tests pass, linting okay but as I said I'm not a pythonist. the code is running on production and works. currently I don't know how to do a proper testing. sorry |
guilhermef
approved these changes
Aug 8, 2024
|
@pschrammel, can you update your PR? |
|
This PR is stale because it has been open 45 days with no activity. Remove the stale label or add a comment, or this PR will be closed in 10 days. You can always re-open if you feel this is something we should still keep working on. Tag @heynemann for more information. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I don't know if it make much sense to have two configurations. it would have if we'd support different buckets for storage and result storage.