Match API parity with 0.19.0-rc.19 #16
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
micahmo
approved these changes
Dec 5, 2023
| @@ -18,6 +18,7 @@ class CommentView with _$CommentView { | |||
| required CommentAggregates counts, | |||
| required bool creatorBannedFromCommunity, | |||
| bool? creatorIsModerator, // Only available in lemmy v0.19.0 and above | |||
| bool? creatorIsAdmin, // Only available in lemmy v0.19.0 and above | |||
There was a problem hiding this comment.
I wonder if we could use this instead of having to read the post's community's admin list on post load.
There was a problem hiding this comment.
I think so! We can migrate to using this once most instances move to 0.19.x in the future
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is to match parity up to
0.19.0-rc.19: LemmyNet/lemmy-js-client@0.19.0-alpha.18...0.19.0-rc.19.There should be no changes required on Thunder's end to support these changes!