Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Comment text area stops accepting taps after formatting #1464

Closed
sukhmel opened this issue Jun 22, 2024 · 5 comments
Closed

Comment text area stops accepting taps after formatting #1464

sukhmel opened this issue Jun 22, 2024 · 5 comments
Assignees
Labels
bug Something isn't working fixed in upcoming release Indicates that an issue has been fixed, and will be released in the next version
Milestone

Comments

@sukhmel
Copy link

sukhmel commented Jun 22, 2024

Bug Description

Sometimes, when writing a markdown text, input area blinks grey and stops accepting taps, making it impossible to open a keyboard after previewing and complicating navigation.

Expected Behaviour

Text input area should always allow to tap for moving the caret position

Steps to Reproduce

  1. Start writing a comment
  2. Let it's length exceed one line
  3. Input ** for creating a bold text

Additional Context

It seems to never happen when formatted text is on the first line of the input

IIRC, it sometimes requires to also input the paired **, but it may be not necessary

It was happening before 0.4.0 but I was too lazy to report, sorry 😅

App Version

0.5.0-1

Device

Pixel 8 Pro

OS

Android 14, build AP2A.240605.024

@sukhmel sukhmel added the bug Something isn't working label Jun 22, 2024
@sukhmel
Copy link
Author

sukhmel commented Jun 22, 2024

Completely forgot to add the reproduction video:

screen-20240622-132155.2.mp4

@hjiangsu
Copy link
Member

Thanks for the report!

I looked into this, and it seems like Flutter's spell checking is causing exceptions when you input ** characters. I'm not sure if there's any way to fix this except for waiting the fix upstream. For now, I can disable spell checking on the inputs.

@hjiangsu hjiangsu self-assigned this Jun 23, 2024
@hjiangsu hjiangsu added the in-progress Indicates that an issue is currently being worked on label Jun 23, 2024
@hjiangsu hjiangsu added this to the 0.5.0 milestone Jun 23, 2024
@hjiangsu
Copy link
Member

Seems like this issue was already noted down upstream and there is a fix, but we have not yet upgraded to the Flutter version that contains that fix. See #1465 (comment) for reference.

@micahmo
Copy link
Member

micahmo commented Jun 24, 2024

By the way, I just wanted to chime in here and mention that you can use the markdown toolbar to make a word bold, rather than explicitly typing the **. That might help to mitigate this issue!

@hjiangsu hjiangsu added fixed in upcoming release Indicates that an issue has been fixed, and will be released in the next version and removed in-progress Indicates that an issue is currently being worked on labels Jun 25, 2024
@sukhmel
Copy link
Author

sukhmel commented Jun 27, 2024

Yes, I also noticed after reporting that using format buttons helps, it's just that a habit of inputting text manually is too strong 😅

Thank you, will look forward to an update

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working fixed in upcoming release Indicates that an issue has been fixed, and will be released in the next version
Projects
None yet
Development

No branches or pull requests

3 participants