Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix text field spell check causing exception on ** text #1465

Merged
merged 1 commit into from
Jun 24, 2024

Conversation

hjiangsu
Copy link
Member

@hjiangsu hjiangsu commented Jun 23, 2024

Pull Request Description

This is a small PR which fixes the error described in #1464. As mentioned in the original issue, this is caused by Flutter's spell checking engine. For now, I've disabled spell checking until a fix is confirmed from upstream.

Additional Info:
This is the stack trace (the exception doesn't explicitly print out the stack trace in the console):
image
image

The issue most likely comes from final RegExp currentSpanTextRegexp = RegExp('\\b$currentSpanText\\b'); in flutter/lib/src/widgets/spell_check.dart.

Issue Being Fixed

Issue Number: #1464

Screenshots / Recordings

Checklist

  • If a new package was added, did you ensure it uses an appropriate license and is actively maintained?
  • Did you use localized strings (and added appropriate descriptions) where applicable?
  • Did you add semanticLabels where applicable for accessibility?

@hjiangsu
Copy link
Member Author

Update: I found the corresponding Flutter issue, which mentions that it should be fixed: flutter/flutter#136032

Not sure what version it was fixed, but should double check if this is an issue once we upgrade to Flutter 3.22

Copy link
Member

@micahmo micahmo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice find and fix! We can merge this for now as long as we remember to revert it once the upstream fix is included (I know spellcheck is very important to folks!).

On that topic, is there any progress on #1372?

@hjiangsu
Copy link
Member Author

On that topic, is there any progress on #1372?

Not yet, still waiting for packages to be updated! I also saw that flex_color_scheme isn't compatible with Flutter 3.22 either, so we'll have to wait until the next version of that as well (updated the description on #1372 already).

@hjiangsu hjiangsu merged commit 3ee5e52 into develop Jun 24, 2024
1 check passed
@hjiangsu hjiangsu deleted the fix/markdown-text-field branch June 24, 2024 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants