Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upvote and downvote button color customization. #25

Closed
jordan1776 opened this issue Jun 20, 2023 · 3 comments
Closed

Upvote and downvote button color customization. #25

jordan1776 opened this issue Jun 20, 2023 · 3 comments
Assignees
Labels
enhancement New feature or request fixed in upcoming release Indicates that an issue has been fixed, and will be released in the next version
Milestone

Comments

@jordan1776
Copy link

Is your feature request related to a problem? Please describe.
This is related to this discussion

Describe the solution you'd like
Colors for up/downvote should by default match Lemmy's (blue #007bff for up and dark orange #873208). There should a setting in customization to use colors for reddit (orangered/periwinkle) and kbin (green/red)

Additional context
Directly or indirectly asking the user in a first install OOBE what vote colors to user along with post view/gestures/etc could be a nice feature for the future.

@hjiangsu hjiangsu added enhancement New feature or request good first issue Good for newcomers labels Jun 20, 2023
@ShambhavII-Singh
Copy link

hi can you assign this to me?

@jordan1776
Copy link
Author

hi can you assign this to me?

You could check with the Matrix chat if anyone else is working on it. Looking back maybe asking for preset color combos might not have been the best choice and probably using the color picker dialog from "Accent colors" would be better (but I don't think that was a thing back then). One for upvotes and one for downvotes.

@micahmo
Copy link
Member

micahmo commented Aug 28, 2023

Hey @ShambhavII-Singh, I've assigned this issue to you for now. As @jordan1776 said, you're welcome to join the devs in Matrix at https://matrix.to/#/#thunderapp:matrix.org. There you'll have a better idea of who's doing what. But of course, you're welcome to contribute without joining or even being assigned an issue. PRs are welcome!

To @jordan1776's point about colors, we have been leaning heavily into coloring elements based on the current theme using alphaBlend (example). But I also get the desire to set specific colors for upvote/downvote. Feel free to put together a proposal and we'll let the community weigh in!

@hjiangsu hjiangsu added fixed in upcoming release Indicates that an issue has been fixed, and will be released in the next version and removed good first issue Good for newcomers labels May 11, 2024
@hjiangsu hjiangsu added this to the 0.4.0 milestone May 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request fixed in upcoming release Indicates that an issue has been fixed, and will be released in the next version
Projects
None yet
Development

No branches or pull requests

4 participants