Add support for customizable action colors #1304
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
micahmo
changed the title
hjiangsu
approved these changes
Apr 29, 2024
There was a problem hiding this comment.
LGTM, just one comment!
Could you also add in red as a colour option? This request comes from https://lemmy.world/comment/9492460
Done! qemu-system-x86_64_WvZxOUA7IK.mp4 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
The PR adds the ability to customize the colors for the following actions in Thuder.
These colors apply to swipe gestures, inkwells, status indicators, etc. Note that we can pretty easily add more colors in the future. It should also be possible for us to use a similar mechanism to customize other colors in the app (e.g., nested comment indicators or media badge indicators).
Finally, there is a new settings hint in the gestures page which points to this new setting.
As this was quite a big change, please be on the lookout for unusual colors!
Issue Being Fixed
Issue Number: #1301 and #25
Screenshots / Recordings
qemu-system-x86_64_TvvCCRv4Vt.mp4
Checklist
semanticLabels where applicable for accessibility?