Improved cross-post UI #1332
Improved cross-post UI #1332
Conversation
# Conflicts: # lib/community/widgets/post_card_metadata.dart # lib/post/widgets/post_view.dart # lib/shared/cross_posts.dart
There was a problem hiding this comment.
Hey @CTalvio, we've missed your contributions! 😊
I love the idea of this, even more than what I was trying to add in #1322. I think all of this extra metadata is critical to deciding whether you're interested in viewing a cross-post.
Here are some of my observations.
- All of the inkwells have hard corners (we usually use something like a radius of 5 or 10), although an alternative here would be to make the widget edge-to-edge and then it wouldn't need to be rounded).
- The CrossPosts widget has an inkwell effect even when there's only one cross-post (i.e., it looks tappable, but tapping does nothing).
- The inkwell around the community name seems to have some space at the end.
And then I just had a couple thoughts to potentially increase the usability of the feature.
- What do you think about the default view just being a single statement like "Cross-posted to 1 community"/"Cross-posted to 2 communities" with a down arrow that you have to expand. I think that would alleviate some concerns about the metadata being confused with the main post. You would have to expand to see the metadata, even for a single cross-post.
- What do you think about having the whole row tappable instead of just the community name, so it's more clear that you're navigating to the post and not the community (I think that would be an improvement over the current UX).
Nice work, I think this looks awesome, and I would definitely like to pursue this path over the one I started. 😊
|
I glad you approve! You bring up several thoughts I've had myself since yesterday. I'll fiddle with this further 👍 |
Kooha-2024-04-29-21-39-15.mp4Now looks like this. |
|
Hang on. Gonna check how it works in post creation. |
|
Done |
|
Just FYI, I briefly get an error when loading the create post screen. Then it works fine once the results have come in. qemu-system-x86_64_SPW5GJy0pR.mp4 |
|
Must have been happening with old crosspost info too, then, but thats an easy fix |
Probably so. Thanks a bunch! |
Pull Request Description
Improves cross posting UI
Issue Being Fixed
Cosmetics and metadata visibility. Provides similar and additional functionality to #1322
Screenshots / Recordings
Checklist
semanticLabels where applicable for accessibility?