Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CI workflow to check for sorted translations #1059

Merged
merged 4 commits into from
Jan 15, 2024

Conversation

hjiangsu
Copy link
Member

Pull Request Description

This PR adds a workflow which checks if the translation entries are sorted in alphabetical order. It also removes this workflow: "Create Empty .env File" since its no longer needed.

Issue Being Fixed

Issue Number: N/A

Screenshots / Recordings

Checklist

  • Did you update CHANGELOG.md?
  • Did you use localized strings where applicable?
  • Did you add semanticLabels where applicable for accessibility?

Copy link
Member

@micahmo micahmo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very cool!

We could also have a PR (like the instances one) which just opens a PR to fix this rather than failing existing PRs.

@hjiangsu
Copy link
Member Author

We could also have a PR (like the instances one) which just opens a PR to fix this rather than failing existing PRs.

Should be possible! I'm just not too sure how it interacts with Weblate (whether it'll detect merge errors, etc) which is why I'm keeping it as part of the CI for now

@hjiangsu hjiangsu merged commit eade1f7 into develop Jan 15, 2024
@hjiangsu hjiangsu deleted the ci/sorted-translations branch January 15, 2024 22:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants