Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix community search issues #1149

Merged
merged 1 commit into from
Feb 27, 2024

Conversation

micahmo
Copy link
Member

@micahmo micahmo commented Feb 27, 2024

Pull Request Description

This PR includes a few changes for the community search page.

  1. Focus the search box immediately. Unlike the main search page, there is no other content here, so I think it makes sense to jump right to searching.
  2. Fix an issue with search state being lost when navigating back via the Android gesture.
    • I discovered that, when using the Android back button, the SwipeablePageRoute will rebuild itself, causing the blocs that it creates to be reconstructed from scratch. The fix is simply to construct the bloc outside of the SwipeablePageRoute. (This could possibly help with solving #1109 as well!).

Issue Being Fixed

Issue Number: N/A

Screenshots / Recordings

Issue 1

focus_search.mp4

Issue 2 Before

state_issue_before.mp4

Issue 2 After

state_issue_after.mp4

Checklist

  • Did you update CHANGELOG.md?
  • Did you use localized strings where applicable?
  • Did you add semanticLabels where applicable for accessibility?

@hjiangsu
Copy link
Member

LGTM!

@hjiangsu hjiangsu merged commit c1062b1 into thunder-app:develop Feb 27, 2024
1 check passed
@micahmo micahmo deleted the fix/community-search-issues branch February 27, 2024 19:45
@micahmo micahmo mentioned this pull request Feb 28, 2024
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants