Fixes to spoiler markdown regex matching #1170
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
This PR aims to fix all of the spoiler markdown issues mentioned in #1166 and more! Furthermore, it disables the custom inline spoiler that was introduced previously since that's not a Lemmy compatible feature.
I did some extensive testing on this to try to catch all the possible edge cases for spoilers. It's heavily documented in this post: https://lemmy.ca/post/10783302
Issue Being Fixed
Issue Number: #1166
Screenshots / Recordings
Checklist
semanticLabels where applicable for accessibility?