Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CommunitySelector format #1172

Merged
merged 1 commit into from
Mar 7, 2024

Conversation

micahmo
Copy link
Member

@micahmo micahmo commented Mar 6, 2024

Pull Request Description

This PR fixes an issue where the CommunitySelector would not respect the selected community full name syntax. It was using getLemmyCommunity which is more for resolving and verifying the identity of a community to a common syntax with which we can navigate. Instead it should have used generateCommunityFullName which is purely a textual transformation. This change should also slightly reduce the overhead of calling getLemmyCommunity which was async.

Issue Being Fixed

Issue Number: N/A

Screenshots / Recordings

Checklist

  • Did you update CHANGELOG.md?
  • Did you use localized strings where applicable?
  • Did you add semanticLabels where applicable for accessibility?

Copy link
Member

@hjiangsu hjiangsu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@hjiangsu hjiangsu merged commit 4cdf5f1 into thunder-app:develop Mar 7, 2024
1 check passed
@micahmo micahmo deleted the fix/community-selector-name branch March 7, 2024 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants