Fix tagline issue

[micahmo]

Pull Request Description

This PR fixes the first issue mentioned in #961 by extracting the tagline selection logic out of the TagLine widget so that a new one is not chosen every time the widget builds. The cache has also been removed, so that a tagline is only chosen once initially, and then again when a refresh occurs.

Issue Being Fixed

Issue Number: #961

Screenshots / Recordings

See #961 for the before video.

qemu-system-x86_64_9BQMBnCJhI.mp4

Checklist

• Did you update CHANGELOG.md?
• Did you use localized strings where applicable?
• Did you add semanticLabels where applicable for accessibility?

[hjiangsu]

LGTM! I believe there was another issue where non-logged in accounts were not able to see Taglines? I think that is a different issue than this but wanted to bring it back up.

I think it's a result of us using context.read<AuthBloc>().state.getSiteResponse which is only filled in when logged in, but I could be wrong about that.

[micahmo]

I believe there was another issue where non-logged in accounts were not able to see Taglines? I think that is a different issue than this but wanted to bring it back up.

I think it's a result of us using context.read<AuthBloc>().state.getSiteResponse which is only filled in when logged in, but I could be wrong about that.

That would make sense! It would explain why they keep working when switching to an anonymous instance (because getSiteResponse might not get cleared out), but they stop working when you restart.

I can try to look at that when I get a chance.